From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FBE7C54E76 for ; Mon, 20 Nov 2023 11:37:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233088AbjKTLhk (ORCPT ); Mon, 20 Nov 2023 06:37:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232582AbjKTLhi (ORCPT ); Mon, 20 Nov 2023 06:37:38 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 415089C; Mon, 20 Nov 2023 03:37:35 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EADC721904; Mon, 20 Nov 2023 11:37:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1700480253; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9XtkkkpmPUqOV5wGnu9VXko/EkG5FheGW/d/tOMb0r0=; b=E7EQxnerNqx/xhapJYSCpse58nlaIvZ2aWhEJxdr1YdQ8Bln+apuPte6Ba6U7RV6BR9rVJ fEMV62ErQiR9i0pDsMEUgs41jUmW+p7C+xYumHPPgpd8D/8rnb9ZNwGfdqtN1CWLg2CumG PyELPZUF2BFsUfwN4mle1mnQ1Bhh93I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1700480253; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9XtkkkpmPUqOV5wGnu9VXko/EkG5FheGW/d/tOMb0r0=; b=WqY1QIIKSNjauUCtaetBn8RuVnrBxvgBnBVQ2nKjGxScjrNFVTyqhyKNe/0ma/kfZfK+SU AHD5/iskRcZhKnCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B051F13499; Mon, 20 Nov 2023 11:37:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id NwNEKv1EW2UEPQAAMHmgww (envelope-from ); Mon, 20 Nov 2023 11:37:33 +0000 Date: Mon, 20 Nov 2023 12:37:33 +0100 Message-ID: <87zfz8psea.wl-tiwai@suse.de> From: Takashi Iwai To: Stefan Binding Cc: Mark Brown , Jaroslav Kysela , "Takashi Iwai" , , , , Subject: Re: [PATCH v2 0/2] ALSA: cs35l41: prevent old firmwares using unsupported commands In-Reply-To: <20231117163609.823627-1-sbinding@opensource.cirrus.com> References: <20231117163609.823627-1-sbinding@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Authentication-Results: smtp-out1.suse.de; none X-Spamd-Result: default: False [-0.88 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.999]; RCPT_COUNT_SEVEN(0.00)[8]; MID_CONTAINS_FROM(1.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-0.58)[81.44%] Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 17 Nov 2023 17:36:07 +0100, Stefan Binding wrote: > > Some systems use older firmware which does not support newer commands > which are used to enable external boost. For those systems, we can > workaround this by writing the registers directly. > > We can use the firmware version, stored inside cs_dsp, to determine > whether or not the command is supported. > To achieve this, it requires a cleanup in the api, to pass the cs_dsp > struct into the function. > > We can also remove the redundant boolean firmware_running from the HDA > driver, and use the equivalent state inside cs_dsp. > > Changes since V1: > - Added fixes tag to all patches > - patches rebased after v6.7 release > > Stefan Binding (2): > ALSA: hda: cs35l41: Remove unnecessary boolean state variable > firmware_running > ALSA: cs35l41: Fix for old systems which do not support command Both patches applied now. Thanks. Takashi