From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13E4AC25B67 for ; Thu, 26 Oct 2023 16:03:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235226AbjJZQDS (ORCPT ); Thu, 26 Oct 2023 12:03:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235230AbjJZQDE (ORCPT ); Thu, 26 Oct 2023 12:03:04 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF2A61700; Thu, 26 Oct 2023 09:02:24 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B468721AD4; Thu, 26 Oct 2023 16:02:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1698336142; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L3jBrvFhTDe3eSEyZfXz/IDIQ4Au/tRbSyyjMpWYOH4=; b=p7FXIHhl4tnDCzRNTEN0pQxOwffpZn5iv4Zb/cDJxuf9BpruBhMQI87kMN4UD6LBHEefif 4lmAw5PB/fLAkdPVFkaQ5FXocGHzfmrsITxxwqVuqRslLZLmqw/KarwmyRs9FEiyd5+rbC 8NMv+eH/LH5NpwhbKUnvSyZgib7l0d8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1698336142; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L3jBrvFhTDe3eSEyZfXz/IDIQ4Au/tRbSyyjMpWYOH4=; b=9BRuisOQJv2wORhgQ/1G/i13/Ps0I0A8/dEhcAzhyJbD79zrf9Rbuiw+Sn/M/KxYdorOcw ddH6E/lP/YNdQrAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7C831133F5; Thu, 26 Oct 2023 16:02:22 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id qlNbHY6NOmUPDAAAMHmgww (envelope-from ); Thu, 26 Oct 2023 16:02:22 +0000 Date: Thu, 26 Oct 2023 18:02:21 +0200 Message-ID: <87zg05xtgy.wl-tiwai@suse.de> From: Takashi Iwai To: Stefan Binding Cc: Jaroslav Kysela , Takashi Iwai , "Mark Brown" , , , , Subject: Re: [PATCH v1 0/8] System Suspend fixes and improvements for CS35L41 HDA In-Reply-To: <20231026150558.2105827-1-sbinding@opensource.cirrus.com> References: <20231026150558.2105827-1-sbinding@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Authentication-Results: smtp-out1.suse.de; none X-Spamd-Result: default: False [-8.35 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-3.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; REPLY(-4.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCPT_COUNT_SEVEN(0.00)[8]; MID_CONTAINS_FROM(1.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-1.25)[89.59%] Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 26 Oct 2023 17:05:50 +0200, Stefan Binding wrote: > > There is a report of a single laptop which uses CS35L41 HDA having an > issue with System Suspend. This particular laptop uses S3 (Deep) Sleep. > The reported issue states that when the laptop resumes from a system > suspend, audio no longer works. > > The root cause of this issue is due to the CS35L41 being returned to us > in an unexpected state after a suspend/resume cycle. > When the driver resumes, it expects the parts to have been reset, which > leads to issues with audio and firmware loading. > > To prevent this issue, and the possibility of similar issues, patches > 2-5 force the driver to reset during probe, system suspend, and system > resume, which ensures that the part is always in the correct state. > Patches 6-8 are improvements in the suspend and firmware loading code, > which makes it easier to detect issues in the future, as well as > simplifiying the suspend code. > > Patch 1 is a fix for an incorrect configuration for the HP Zbook Fury > 17, which is the laptop which had the original issue. > > Stefan Binding (8): > ALSA: hda: cs35l41: Use reset label to get GPIO for HP Zbook Fury 17 > G9 > ALSA: hda: cs35l41: Assert reset before system suspend > ALSA: hda: cs35l41: Assert Reset prior to de-asserting in probe and > system resume > ALSA: hda: cs35l41: Run boot process during resume callbacks > ALSA: hda: cs35l41: Force a software reset after hardware reset > ALSA: hda: cs35l41: Do not unload firmware before reset in system > suspend > ALSA: hda: cs35l41: Check CSPL state after loading firmware > ASoC: cs35l41: Detect CSPL errors when sending CSPL commands Applied to for-next branch now. Thanks. Takashi