From: Kalle Valo <kvalo@kernel.org>
To: Christian Lamparter <chunkeey@gmail.com>
Cc: Wu Yunchuan <yunchuan@nfschina.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2 wireless-next 2/9] carl9170: remove unnecessary (void*) conversions
Date: Thu, 28 Sep 2023 18:31:28 +0300 [thread overview]
Message-ID: <87zg16iab3.fsf@kernel.org> (raw)
In-Reply-To: <e544d992-cddd-4ade-81ef-2eed4f3681e8@gmail.com> (Christian Lamparter's message of "Wed, 20 Sep 2023 21:00:08 +0200")
Christian Lamparter <chunkeey@gmail.com> writes:
> On 9/19/23 06:49, Wu Yunchuan wrote:
>> No need cast (void *) to (struct ar9170 *), (u8 *) or (void*).
>
> hmm, your mail went into the spam folder. Good thing I checked.
>
> From what I remember: The reason why these casts were added in
> carl9170 was because of compiler warnings/complaints.
> Current gcc compilers should be OK (given that the kernel-bot
> didn't react, or went your Mail to their spam-folder as well?)
> but have you checked these older versions?
Do you remember anything more about these warnings? I tried to check the
git history and at least quickly couldn't find anything related to this.
The changes look very safe to me, struct urb::context field and the out
variable are both of type 'void *' so removing the explicit casts should
change anything. I cannot really come up a reason why would this patch
cause new warnings so I am inclined towards taking this patch. What do
you think?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2023-09-28 15:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 4:49 [PATCH v2 wireless-next 2/9] carl9170: remove unnecessary (void*) conversions Wu Yunchuan
2023-09-20 18:15 ` Jeff Johnson
2023-09-20 19:00 ` Christian Lamparter
2023-09-22 1:33 ` yunchuan
2023-09-28 15:31 ` Kalle Valo [this message]
2023-09-28 19:26 ` Jeff Johnson
2023-09-29 6:43 ` Dan Carpenter
2023-09-29 6:49 ` Dan Carpenter
2023-09-29 7:23 ` Christian Lamparter
2023-09-29 12:26 ` Dan Carpenter
2023-09-29 12:30 ` Dan Carpenter
2023-09-29 16:10 ` Jeff Johnson
2023-09-29 17:22 ` Jeff Johnson
2023-10-02 16:57 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zg16iab3.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=chunkeey@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=yunchuan@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox