From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8723AE732E6 for ; Thu, 28 Sep 2023 15:29:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231860AbjI1P33 (ORCPT ); Thu, 28 Sep 2023 11:29:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231384AbjI1P3Z (ORCPT ); Thu, 28 Sep 2023 11:29:25 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9EDBDAC; Thu, 28 Sep 2023 08:29:23 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21992C433C8; Thu, 28 Sep 2023 15:29:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695914963; bh=BwRgdNKeJxIJ5cr5vGTDyf7GQ4JC9jrjgb1r743JPlg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=PcufRPF3oYqO7p9A49NFfI9TrSP5l1pdFXe4cJ988aZz++6Aa/6vLvjXmy/+eFu/v 9OGGSJmSq8O0P7jaSnGPmWbvWIc+lq5/fK3rcYDa4yDwttGRsmY/U5CawBTzd/fo4v B/v5t3odugztw5Rm3k6wIBUxdhAxxNhu0uk/IlK+RHFjygZorfrnpFsyvonA95SgKQ dQ6UIJt7TYaPDou5UW8tToBF0iu0sSMhkkRNLQ8daU1ftkPqcQP7pGgaSyVzhbSbfy bF/hCFfsg6gDEhAdiwFfKd02qb9/ueyh25E2mxRLkkdEoaFhh3r3I38u7FFdEARFdH JdSeRK2GtLOKw== From: Kalle Valo To: Christian Lamparter Cc: Wu Yunchuan , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH v2 wireless-next 2/9] carl9170: remove unnecessary (void*) conversions References: <20230919044916.523308-1-yunchuan@nfschina.com> Date: Thu, 28 Sep 2023 18:31:28 +0300 In-Reply-To: (Christian Lamparter's message of "Wed, 20 Sep 2023 21:00:08 +0200") Message-ID: <87zg16iab3.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christian Lamparter writes: > On 9/19/23 06:49, Wu Yunchuan wrote: >> No need cast (void *) to (struct ar9170 *), (u8 *) or (void*). > > hmm, your mail went into the spam folder. Good thing I checked. > > From what I remember: The reason why these casts were added in > carl9170 was because of compiler warnings/complaints. > Current gcc compilers should be OK (given that the kernel-bot > didn't react, or went your Mail to their spam-folder as well?) > but have you checked these older versions? Do you remember anything more about these warnings? I tried to check the git history and at least quickly couldn't find anything related to this. The changes look very safe to me, struct urb::context field and the out variable are both of type 'void *' so removing the explicit casts should change anything. I cannot really come up a reason why would this patch cause new warnings so I am inclined towards taking this patch. What do you think? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches