Re: [PATCH] mfd: cs42l43: Use correct macro for new-style PM runtime ops

[Michael Ellerman <mpe@ellerman.id.au>]

Lee Jones <lee@kernel.org> writes:
> On Tue, 22 Aug 2023, Charles Keepax wrote:
>
>> The code was accidentally mixing new and old style macros, update the
>> macros used to remove an unused function warning whilst building with
>> no PM enabled in the config.
>> 
>> Fixes: ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver")
>> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
>> ---
>>  drivers/mfd/cs42l43.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/drivers/mfd/cs42l43.c b/drivers/mfd/cs42l43.c
>> index 37b23e9bae823..7b6d07cbe6fc6 100644
>> --- a/drivers/mfd/cs42l43.c
>> +++ b/drivers/mfd/cs42l43.c
>> @@ -1178,8 +1178,8 @@ static int cs42l43_runtime_resume(struct device *dev)
>>  }
>>  
>>  EXPORT_NS_GPL_DEV_PM_OPS(cs42l43_pm_ops, MFD_CS42L43) = {
>> -	SET_SYSTEM_SLEEP_PM_OPS(cs42l43_suspend, cs42l43_resume)
>> -	SET_RUNTIME_PM_OPS(cs42l43_runtime_suspend, cs42l43_runtime_resume, NULL)
>> +	SYSTEM_SLEEP_PM_OPS(cs42l43_suspend, cs42l43_resume)
>> +	RUNTIME_PM_OPS(cs42l43_runtime_suspend, cs42l43_runtime_resume, NULL)
>>  };
>>  
>>  MODULE_DESCRIPTION("CS42L43 Core Driver");
>
> Acked-by: Lee Jones <lee@kernel.org>
>
> If anyone wants to submit this directly to Linus before -rc1, please, be
> my guest.

But you're the MFD maintainer, aren't you? So I think everyone is
expecting you to send it to Linus.

cheers