* [PATCH] cpu/SMT: Fix cpu_smt_possible() comment
@ 2023-07-10 3:21 Zhang Rui
2023-07-10 7:36 ` Vitaly Kuznetsov
2023-07-28 7:34 ` Thomas Gleixner
0 siblings, 2 replies; 4+ messages in thread
From: Zhang Rui @ 2023-07-10 3:21 UTC (permalink / raw)
To: tglx, peterz; +Cc: linux-kernel, vkuznets
The comment of cpu_smt_possible() is not aligned with the changelog of
commit e1572f1d08be ("cpu/SMT: create and export cpu_smt_possible()"),
and it is wrong.
Fix cpu_smt_possible() comment.
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
---
kernel/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/cpu.c b/kernel/cpu.c
index 7e8f1b044772..f6811c857102 100644
--- a/kernel/cpu.c
+++ b/kernel/cpu.c
@@ -676,7 +676,7 @@ static inline bool cpu_smt_allowed(unsigned int cpu)
return !cpumask_test_cpu(cpu, &cpus_booted_once_mask);
}
-/* Returns true if SMT is not supported of forcefully (irreversibly) disabled */
+/* Returns true if SMT is supported and not forcefully (irreversibly) disabled */
bool cpu_smt_possible(void)
{
return cpu_smt_control != CPU_SMT_FORCE_DISABLED &&
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] cpu/SMT: Fix cpu_smt_possible() comment
2023-07-10 3:21 [PATCH] cpu/SMT: Fix cpu_smt_possible() comment Zhang Rui
@ 2023-07-10 7:36 ` Vitaly Kuznetsov
2023-07-28 7:34 ` Thomas Gleixner
1 sibling, 0 replies; 4+ messages in thread
From: Vitaly Kuznetsov @ 2023-07-10 7:36 UTC (permalink / raw)
To: Zhang Rui; +Cc: linux-kernel, tglx, peterz
Zhang Rui <rui.zhang@intel.com> writes:
> The comment of cpu_smt_possible() is not aligned with the changelog of
> commit e1572f1d08be ("cpu/SMT: create and export cpu_smt_possible()"),
> and it is wrong.
>
> Fix cpu_smt_possible() comment.
>
> Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> ---
> kernel/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/cpu.c b/kernel/cpu.c
> index 7e8f1b044772..f6811c857102 100644
> --- a/kernel/cpu.c
> +++ b/kernel/cpu.c
> @@ -676,7 +676,7 @@ static inline bool cpu_smt_allowed(unsigned int cpu)
> return !cpumask_test_cpu(cpu, &cpus_booted_once_mask);
> }
>
> -/* Returns true if SMT is not supported of forcefully (irreversibly) disabled */
> +/* Returns true if SMT is supported and not forcefully (irreversibly) disabled */
> bool cpu_smt_possible(void)
> {
> return cpu_smt_control != CPU_SMT_FORCE_DISABLED &&
The function must've had a different name in an earlier version of the
patch...
Thanks for catching this!
Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
--
Vitaly
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cpu/SMT: Fix cpu_smt_possible() comment
2023-07-10 3:21 [PATCH] cpu/SMT: Fix cpu_smt_possible() comment Zhang Rui
2023-07-10 7:36 ` Vitaly Kuznetsov
@ 2023-07-28 7:34 ` Thomas Gleixner
2023-07-28 15:57 ` Zhang, Rui
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Gleixner @ 2023-07-28 7:34 UTC (permalink / raw)
To: Zhang Rui, peterz; +Cc: linux-kernel, vkuznets
On Mon, Jul 10 2023 at 11:21, Zhang Rui wrote:
> The comment of cpu_smt_possible() is not aligned with the changelog of
> commit e1572f1d08be ("cpu/SMT: create and export cpu_smt_possible()"),
> and it is wrong.
Why? Do I need to go and read that commit log and figure out what's wrong?
> Fix cpu_smt_possible() comment.
Zero information.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cpu/SMT: Fix cpu_smt_possible() comment
2023-07-28 7:34 ` Thomas Gleixner
@ 2023-07-28 15:57 ` Zhang, Rui
0 siblings, 0 replies; 4+ messages in thread
From: Zhang, Rui @ 2023-07-28 15:57 UTC (permalink / raw)
To: tglx@linutronix.de, peterz@infradead.org
Cc: linux-kernel@vger.kernel.org, vkuznets@redhat.com
Hi, Thomas,
On Fri, 2023-07-28 at 09:34 +0200, Thomas Gleixner wrote:
> On Mon, Jul 10 2023 at 11:21, Zhang Rui wrote:
> > The comment of cpu_smt_possible() is not aligned with the changelog
> > of
> > commit e1572f1d08be ("cpu/SMT: create and export
> > cpu_smt_possible()"),
> > and it is wrong.
>
> Why? Do I need to go and read that commit log and figure out what's
> wrong?
>
> > Fix cpu_smt_possible() comment.
>
> Zero information.
>
Thanks for reviewing. Sent patch V2 with changelog rephrased.
thanks,
rui
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-28 15:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-10 3:21 [PATCH] cpu/SMT: Fix cpu_smt_possible() comment Zhang Rui
2023-07-10 7:36 ` Vitaly Kuznetsov
2023-07-28 7:34 ` Thomas Gleixner
2023-07-28 15:57 ` Zhang, Rui
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox