From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4458DEB64D9 for ; Sat, 17 Jun 2023 07:35:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346185AbjFQHft (ORCPT ); Sat, 17 Jun 2023 03:35:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229933AbjFQHfq (ORCPT ); Sat, 17 Jun 2023 03:35:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4482FB5 for ; Sat, 17 Jun 2023 00:35:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BF8BA60DE8 for ; Sat, 17 Jun 2023 07:35:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30B8CC433C0; Sat, 17 Jun 2023 07:35:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686987344; bh=c9UO8nssl2fK59bC4qDdVj1LTFQ2SWZ6qfnG2mSUeDo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hrG2lXSfWvauenyqD88/Ei4/B6oTOR3BBVsNo+7DUfCJ/kQKZRMrBM9DKEdVFWLlz 2gjelx6dA5DUbG5eU4fGXmjMiTiwBk+96jfhwWN87li8gBEGeXTXCxfBRW0padEyGw Is/IQqOYI6BmA3u3lAydDADDlUY/HrHR7NYIBjX4/5D/jUisQpmWVWBgJ+78gw9OyI XALApiIuO9LIrRgbo0UrImw1N5Efb8/fB98kjF1eOhXRpp1gUGy8UscwYV3BlRhre3 5hMT+X3cKFv536cdGBn74cTjTQjI9uvbMHYnO0YkTCbFJ0SsPvY3qG5f3GfFFxU5J9 /uCZJ7fBTCOlA== Received: from [77.240.177.73] (helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qAQTF-0063wk-Qd; Sat, 17 Jun 2023 08:35:41 +0100 Date: Sat, 17 Jun 2023 08:35:45 +0100 Message-ID: <87zg4ypmlq.wl-maz@kernel.org> From: Marc Zyngier To: Kunkun Jiang Cc: Thomas Gleixner , Zenghui Yu , "open list:IRQCHIP DRIVERS" , , , Subject: Re: [PATCH] irqchipi/gic-v4: Ensure accessing the correct RD when and writing INVLPIR In-Reply-To: References: <20230412041510.497-1-jiangkunkun@huawei.com> <86y1mxl9m4.wl-maz@kernel.org> <86bkikmvjk.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 77.240.177.73 X-SA-Exim-Rcpt-To: jiangkunkun@huawei.com, tglx@linutronix.de, yuzenghui@huawei.com, linux-kernel@vger.kernel.org, wanghaibin.wang@huawei.com, chenxiang66@hisilicon.com, tangnianyao@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 16 May 2023 13:01:59 +0100, Kunkun Jiang wrote: > > Hi Marc, > > On 2023/5/16 18:15, Marc Zyngier wrote: > > On Thu, 13 Apr 2023 04:57:17 +0100, > > Kunkun Jiang wrote: > >>> Wouldn't it be nice if irq_to_cpuid() could work out whether it is > >>> dealing with a LPI or a VLPI like it does today, but also directly > >>> with a VPE? We could then use the same code as derect_lpi_inv(). I > >>> came up with this the hack below, which is totally untested as I don't > >>> have access to GICv4.1 HW. > >>> > >>> Could you give it a spin? > >> Nice, I will test it as soon as possible. > > Did you ever managed to test this? > Sorry,I've only been coordinating the GICv4.1 environment in the last > few days. I have tested it with GICv4 many times, and it doesn't recur. > However, another call trace occurs with GICv4.1 when the device driver > is loaded in Guest. I haven't found out why. Maybe you can help analyze it. I also went back to my patch, and it is a bit bogus (it doesn't even compile to start with). I've now posted new version[1] that should at least fix the bug you initially reported. Can you please test it and reply to it? Thanks, M. [1] https://lore.kernel.org/r/20230617073242.3199746-1-maz@kernel.org -- Without deviation from the norm, progress is not possible.