From: Michael Ellerman <mpe@ellerman.id.au>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Anatolij Gustschin" <agust@denx.de>
Cc: Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/mpc52xx_lpbfifo: Drop unused functions
Date: Thu, 13 Apr 2023 10:11:25 +1000 [thread overview]
Message-ID: <87zg7cabf6.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <20230412150524.ojsvukh47hing6db@pengutronix.de>
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes:
> On Wed, Dec 28, 2022 at 03:51:29PM +0100, Uwe Kleine-König wrote:
>> The four exported functions mpc52xx_lpbfifo_submit(),
>> mpc52xx_lpbfifo_abort(), mpc52xx_lpbfifo_poll(), and
>> mpc52xx_lpbfifo_start_xfer() are not used. So they can be dropped and the
>> definitions needed to call them can be moved into the driver file.
>>
>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> I never got feedback about this driver and it has not appeared in next
> up to now. Did it fell through the cracks?
Yeah. I was hoping someone would explain what's going on with the
driver.
Presumably there are some out-of-tree drivers that use the routines
provided by this driver?
I think rather than merging this patch, which keeps the code but makes
it completely useless, do you mind sending a patch to remove the whole
driver? Maybe that will get someone's attention.
cheers
next prev parent reply other threads:[~2023-04-13 0:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-28 14:51 [PATCH] powerpc/mpc52xx_lpbfifo: Drop unused functions Uwe Kleine-König
2022-12-29 17:28 ` Uwe Kleine-König
2023-04-12 15:05 ` Uwe Kleine-König
2023-04-13 0:11 ` Michael Ellerman [this message]
2023-04-13 6:16 ` [PATCH] powerpc: Drop MPC5200 LocalPlus bus FIFO driver Uwe Kleine-König
2023-05-09 8:21 ` Uwe Kleine-König
2023-05-12 2:42 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zg7cabf6.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=agust@denx.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox