From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Pali Rohár" <pali@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fat: Fix return value of vfat_bad_char() and vfat_replace_char() functions
Date: Tue, 10 Jan 2023 18:17:52 +0900 [thread overview]
Message-ID: <87zgaqu4sf.fsf@mail.parknet.co.jp> (raw)
In-Reply-To: <20221226142512.13848-1-pali@kernel.org> ("Pali Rohár"'s message of "Mon, 26 Dec 2022 15:25:12 +0100")
Pali Rohár <pali@kernel.org> writes:
> These functions returns boolean value not wide character.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
Thanks.
Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
> ---
> fs/fat/namei_vfat.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/fat/namei_vfat.c b/fs/fat/namei_vfat.c
> index 21620054e1c4..0735e4f0aeed 100644
> --- a/fs/fat/namei_vfat.c
> +++ b/fs/fat/namei_vfat.c
> @@ -200,7 +200,7 @@ static const struct dentry_operations vfat_dentry_ops = {
>
> /* Characters that are undesirable in an MS-DOS file name */
>
> -static inline wchar_t vfat_bad_char(wchar_t w)
> +static inline bool vfat_bad_char(wchar_t w)
> {
> return (w < 0x0020)
> || (w == '*') || (w == '?') || (w == '<') || (w == '>')
> @@ -208,7 +208,7 @@ static inline wchar_t vfat_bad_char(wchar_t w)
> || (w == '\\');
> }
>
> -static inline wchar_t vfat_replace_char(wchar_t w)
> +static inline bool vfat_replace_char(wchar_t w)
> {
> return (w == '[') || (w == ']') || (w == ';') || (w == ',')
> || (w == '+') || (w == '=');
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
prev parent reply other threads:[~2023-01-10 9:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-26 14:25 [PATCH] fat: Fix return value of vfat_bad_char() and vfat_replace_char() functions Pali Rohár
2023-01-10 9:17 ` OGAWA Hirofumi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgaqu4sf.fsf@mail.parknet.co.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pali@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox