public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Luke D. Jones" <luke@ljones.dev>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
	tiwai@suse.com, perex@perex.cz
Subject: Re: [PATCH] Fixes bc2c23549ccd ("ALSA: hda/realtek: Add pincfg for ASUS G533Z HP jack")
Date: Mon, 10 Oct 2022 14:45:23 +0200	[thread overview]
Message-ID: <87zge3etjw.wl-tiwai@suse.de> (raw)
In-Reply-To: <20221010065702.35190-1-luke@ljones.dev>

On Mon, 10 Oct 2022 08:57:02 +0200,
Luke D. Jones wrote:
> 
> The initial fix for ASUS G533Z was based on faulty information. This
> fixes the pincfg to values that have been verified with no existing
> module options or other hacks enabled.
> 
> Enables headphone jack, and 5.1 surround.
> 
> Signed-off-by: Luke D. Jones <luke@ljones.dev>

The changes look OK, but the subject line should be rather describing
what about the patch is about.  I corrected the subject and put the
proper Fixes tag (as well as Cc-to-stable).

Also, the indent level wasn't right, so I corrected it locally, too.


thanks,

Takashi

  reply	other threads:[~2022-10-10 12:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-10  6:57 [PATCH] Fixes bc2c23549ccd ("ALSA: hda/realtek: Add pincfg for ASUS G533Z HP jack") Luke D. Jones
2022-10-10 12:45 ` Takashi Iwai [this message]
2022-10-10 21:50   ` Luke Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zge3etjw.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luke@ljones.dev \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox