[PATCH] Fixes bc2c23549ccd ("ALSA: hda/realtek: Add pincfg for ASUS G533Z HP jack")

[PATCH] Fixes bc2c23549ccd ("ALSA: hda/realtek: Add pincfg for ASUS G533Z HP jack")

[Luke D. Jones]

The initial fix for ASUS G533Z was based on faulty information. This
fixes the pincfg to values that have been verified with no existing
module options or other hacks enabled.

Enables headphone jack, and 5.1 surround.

Signed-off-by: Luke D. Jones <luke@ljones.dev>
---
 sound/pci/hda/patch_realtek.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index bce82b834cec..24406f81da27 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8449,11 +8449,13 @@ static const struct hda_fixup alc269_fixups[] = {
 	[ALC285_FIXUP_ASUS_G533Z_PINS] = {
 		.type = HDA_FIXUP_PINS,
 		.v.pins = (const struct hda_pintbl[]) {
-			{ 0x14, 0x90170120 },
-			{ }
+				{ 0x14, 0x90170152 }, /* Speaker Surround Playback Switch */
+				{ 0x19, 0x03a19020 }, /* Mic Boost Volume */
+				{ 0x1a, 0x03a11c30 }, /* Mic Boost Volume */
+				{ 0x1e, 0x90170151 }, /* Rear jack, IN OUT EAPD Detect */
+				{ 0x21, 0x03211420 },
+				{ }
 		},
-		.chained = true,
-		.chain_id = ALC294_FIXUP_ASUS_G513_PINS,
 	},
 	[ALC294_FIXUP_ASUS_COEF_1B] = {
 		.type = HDA_FIXUP_VERBS,
-- 
2.37.3

Re: [PATCH] Fixes bc2c23549ccd ("ALSA: hda/realtek: Add pincfg for ASUS G533Z HP jack")

[Takashi Iwai]

On Mon, 10 Oct 2022 08:57:02 +0200,
Luke D. Jones wrote:
> 
> The initial fix for ASUS G533Z was based on faulty information. This
> fixes the pincfg to values that have been verified with no existing
> module options or other hacks enabled.
> 
> Enables headphone jack, and 5.1 surround.
> 
> Signed-off-by: Luke D. Jones <luke@ljones.dev>

The changes look OK, but the subject line should be rather describing
what about the patch is about.  I corrected the subject and put the
proper Fixes tag (as well as Cc-to-stable).

Also, the indent level wasn't right, so I corrected it locally, too.


thanks,

Takashi

Re: [PATCH] Fixes bc2c23549ccd ("ALSA: hda/realtek: Add pincfg for ASUS G533Z HP jack")

[Luke Jones]

On Mon, 2022-10-10 at 14:45 +0200, Takashi Iwai wrote:
> On Mon, 10 Oct 2022 08:57:02 +0200,
> Luke D. Jones wrote:
> > 
> > The initial fix for ASUS G533Z was based on faulty information.
> > This
> > fixes the pincfg to values that have been verified with no existing
> > module options or other hacks enabled.
> > 
> > Enables headphone jack, and 5.1 surround.
> > 
> > Signed-off-by: Luke D. Jones <luke@ljones.dev>
> 
> The changes look OK, but the subject line should be rather describing
> what about the patch is about.  I corrected the subject and put the
> proper Fixes tag (as well as Cc-to-stable).
> 
> Also, the indent level wasn't right, so I corrected it locally, too.

Oh... Sorry about the hassle there, I could have sworn it was correct.
Thanks for accepting regardless :)

> 
> thanks,
> 
> Takashi