From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC1F9ECAAD3 for ; Wed, 14 Sep 2022 10:27:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229812AbiINK1e (ORCPT ); Wed, 14 Sep 2022 06:27:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229704AbiINK1b (ORCPT ); Wed, 14 Sep 2022 06:27:31 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 528481A39A for ; Wed, 14 Sep 2022 03:27:30 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D83C93388F; Wed, 14 Sep 2022 10:27:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1663151248; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bwrqe9juwWAngUflkbqX/hdbOSZnvvFPps+5b1Q+D74=; b=XQqiHUQpe0B019/T76+hTeH4+0W8HviqY2hYFqLZrHwYApx+zhPHpqBoYGFkKhKc+duxYZ el7VnnVeClFFGHwEqx8meweuWdnHHPVy8h4HR/OLPbx6ji3x1skEmUc1A6S+kmLMaG5af7 yf2FD0orQKpf7ZiTz/S33xFLoRD/0rE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1663151248; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bwrqe9juwWAngUflkbqX/hdbOSZnvvFPps+5b1Q+D74=; b=cTm91n7Al3Ll6ff/pdR3nNsXfPPYYJ4tJPNU7MHrDKm7tt/dYV3kMdprrjOkyuJ4y9ua2C 1OXk13mzFdWoEZCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A13B1134B3; Wed, 14 Sep 2022 10:27:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id oJC1JpCsIWOfSAAAMHmgww (envelope-from ); Wed, 14 Sep 2022 10:27:28 +0000 Date: Wed, 14 Sep 2022 12:27:28 +0200 Message-ID: <87zgf2tfn3.wl-tiwai@suse.de> From: Takashi Iwai To: Mark Brown Cc: Gaosheng Cui , cezary.rojewski@intel.com, tiwai@suse.com, ranjani.sridharan@linux.intel.com, pierre-louis.bossart@linux.intel.com, perex@perex.cz, liam.r.girdwood@linux.intel.com, kai.vehmanen@linux.intel.com, peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] ASoC: Intel: fix unused-variable warning in probe_codec In-Reply-To: <166314841746.314266.6045600836637107787.b4-ty@kernel.org> References: <20220822035133.2147381-1-cuigaosheng1@huawei.com> <166314841746.314266.6045600836637107787.b4-ty@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-7 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 14 Sep 2022 11:40:17 +0200, Mark Brown wrote: > > On Mon, 22 Aug 2022 11:51:33 +0800, Gaosheng Cui wrote: > > In configurations with CONFIG_SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC=n, > > gcc warns about an unused variable: > > > > sound/soc/intel/skylake/skl.c: In function ˇprobe_codec˘: > > sound/soc/intel/skylake/skl.c:729:18: error: unused variable ˇskl˘ [-Werror=unused-variable] > > struct skl_dev *skl = bus_to_skl(bus); > > ^~~ > > cc1: all warnings being treated as errors > > > > [...] > > Applied to > > broonie/sound.git for-next > > Thanks! > > [1/1] ASoC: Intel: fix unused-variable warning in probe_codec > commit: 515626a33a194c4caaf2879dbf9e00e882582af0 > > All being well this means that it will be integrated into the linux-next > tree (usually sometime in the next 24 hours) and sent to Linus during > the next merge window (or sooner if it is a bug fix), however if > problems are discovered then the patch may be dropped or reverted. > > You may get further e-mails resulting from automated or manual testing > and review of the tree, please engage with people reporting problems and > send followup patches addressing any issues that are reported if needed. > > If any updates are required or you are submitting further changes they > should be sent as incremental updates against current git, existing > patches will not be replaced. > > Please add any relevant lists and maintainers to the CCs when replying > to this mail. I thought the buggy commit 3fd63658caed9 was present only in my tree for now, but if it's in your tree, that's fine to apply through yours. Then I'll drop from mine. thanks, Takashi