From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB7FCC433EF for ; Sat, 16 Jul 2022 06:54:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231396AbiGPGy2 (ORCPT ); Sat, 16 Jul 2022 02:54:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbiGPGyZ (ORCPT ); Sat, 16 Jul 2022 02:54:25 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92A4FBE09 for ; Fri, 15 Jul 2022 23:54:23 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A62093475E; Sat, 16 Jul 2022 06:54:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1657954457; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yry99IA1WiFDK0QH3xD+Tpa/8/BprzTVQgjI5YTP8tw=; b=pJxmN5YPqfN4FPd+/7fqRHKzpkh4xIhF+kcGSlXvou+klWyBpqhxWQQUu4LaGvOOWq5tt9 cbf0ZEy3iTo1VgGJ7I74bWAQeXDhFJKU5V1+WGj68X5BYSs2oJLnQeveTFbI4wGZW7+wdr M5QtquWEzIrSG7SvJXXtwu0yM+Uux0k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1657954457; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yry99IA1WiFDK0QH3xD+Tpa/8/BprzTVQgjI5YTP8tw=; b=7y4am76Ze33aLUyQNN440VQUh37IoGXdcrzZeRr2F6D/wixkidNDk9Eq3KvldtsCx//8M2 MgCbnZFarW2LOQDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8329C13AAD; Sat, 16 Jul 2022 06:54:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8eJDH5lg0mJSaQAAMHmgww (envelope-from ); Sat, 16 Jul 2022 06:54:17 +0000 Date: Sat, 16 Jul 2022 08:54:17 +0200 Message-ID: <87zgh9tuna.wl-tiwai@suse.de> From: Takashi Iwai To: Andy Shevchenko Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Jaroslav Kysela , Takashi Iwai Subject: Re: [PATCH v1 1/1] ALSA: isa: Use INVALID_HWIRQ definition In-Reply-To: <20220715205737.83076-1-andriy.shevchenko@linux.intel.com> References: <20220715205737.83076-1-andriy.shevchenko@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 15 Jul 2022 22:57:37 +0200, Andy Shevchenko wrote: > > Use specific definition for invalid IRQ. It makes the > code uniform in respect to the constant used for that. > No functional change intended. > > Signed-off-by: Andy Shevchenko > --- > sound/isa/sscape.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/sound/isa/sscape.c b/sound/isa/sscape.c > index 0bc0025f7c19..9adaf91045e9 100644 > --- a/sound/isa/sscape.c > +++ b/sound/isa/sscape.c > @@ -140,8 +140,7 @@ struct soundscape { > unsigned char midi_vol; > }; > > -#define INVALID_IRQ ((unsigned)-1) > - > +#define INVALID_IRQ ((unsigned)INVALID_HWIRQ) > > static inline struct soundscape *get_card_soundscape(struct snd_card *c) > { This seems failing to build on my local tree as is. We need to include explicitly. thanks, Takashi