From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53E4EC433EF for ; Wed, 8 Jun 2022 07:15:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235080AbiFHHJ3 (ORCPT ); Wed, 8 Jun 2022 03:09:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233974AbiFHGdN (ORCPT ); Wed, 8 Jun 2022 02:33:13 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EE1022D for ; Tue, 7 Jun 2022 23:33:11 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 172AA21A3D; Wed, 8 Jun 2022 06:33:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1654669990; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KKKF4oXE4aYdOiKY4SmO08b1/YLB9bqfnb1BacExcxU=; b=dxx7YIpiK9xXZHHvO7aKx7DtGeT7hqpCoOfsrFEI3JMbJPBNARAr55AEyWgkGKbMvuDcxA 9VFv8tOavfAXe8SE5u8pE/3x8NKef5mn4cC9NhtGyKQFm1jXBK5mU4qxPGq9pvH3LRsVSD cxOB2jms8CZmSXak3+m7lko3pYL65G0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1654669990; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KKKF4oXE4aYdOiKY4SmO08b1/YLB9bqfnb1BacExcxU=; b=wFI42eGrFzfip4bbxgMxPI9SsC6eIzjiNNUNF8kMG7y8+YHSY6ssRB4mugR2J876NBXme/ WuKLLqSS2yEQ1UDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D2E8A13AD9; Wed, 8 Jun 2022 06:33:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id P3+/MqVCoGJjAwAAMHmgww (envelope-from ); Wed, 08 Jun 2022 06:33:09 +0000 Date: Wed, 08 Jun 2022 08:33:09 +0200 Message-ID: <87zginbr6i.wl-tiwai@suse.de> From: Takashi Iwai To: huangwenhui Cc: tiwai@suse.com, perex@perex.cz, alsa-devel@alsa-project.org, kailang@realtek.com, tanureal@opensource.cirrus.com, jeremy.szu@canonical.com, linux-kernel@vger.kernel.org, wse@tuxedocomputers.com, hui.wang@canonical.com, sami@loone.fi, cam@neo-zeon.de Subject: Re: [PATCH] [PATCH v2]ALSA: hda/realtek - Add HW8326 support In-Reply-To: <20220608062237.8162-1-huangwenhuia@uniontech.com> References: <20220608062237.8162-1-huangwenhuia@uniontech.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 08 Jun 2022 08:22:37 +0200, huangwenhui wrote: > > Added the support of new Huawei codec HW8326.The HW8326 is developed Put a space after a period or a comma (i.e. "... codec HW8326. The HW8326 ...") > by Huawei with Realtek's IP Core, and it's compatible with ALC256. > > Signed-off-by: huangwenhui The subject line shouldn't have two [PATCH*] prefixes. Last but not least, be more careful about spacing. e.g. the subject line should be like: Subject: [PATCH v2] ALSA: hda/realtek - Add HW8326 support See the space between "[PATCH v2]" and "ALSA" words. I can apply the patch with correction in my side, but let's try once again: please try to send out v3 in a perfect form :) thanks, Takashi