Re: [PATCH v3] irq: consider cpus on nodes are unbalanced

Re: [PATCH v3] irq: consider cpus on nodes are unbalanced

[Ming Lei]

On Thu, Feb 10, 2022 at 12:10:53PM +0900, Rei Yamamoto wrote:
> If cpus on a node are offline at boot time, there are
> difference in the number of nodes between when building affinity
> masks for present cpus and when building affinity masks for possible
> cpus. This patch fixes a problem caused by the difference of the
> number of nodes:
> 
>  - The routine of "numvecs <= nodes" condition can overwrite bits of
>    masks for present cpus in building masks for possible cpus. Fix this
>    problem by making CPU bits, which is not target, not changing.
> 
> Signed-off-by: Rei Yamamoto <yamamoto.rei@jp.fujitsu.com>
> Reviewed-by: Ming Lei <ming.lei@redhat.com>
> ---
>  kernel/irq/affinity.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/kernel/irq/affinity.c b/kernel/irq/affinity.c
> index f7ff8919dc9b..d2d01565d2ec 100644
> --- a/kernel/irq/affinity.c
> +++ b/kernel/irq/affinity.c
> @@ -269,8 +269,9 @@ static int __irq_build_affinity_masks(unsigned int startvec,
>  	 */
>  	if (numvecs <= nodes) {
>  		for_each_node_mask(n, nodemsk) {
> +			cpumask_and(nmsk, cpu_mask, node_to_cpumask[n]);
>  			cpumask_or(&masks[curvec].mask, &masks[curvec].mask,
> -				   node_to_cpumask[n]);
> +				   nmsk);
>  			if (++curvec == last_affv)
>  				curvec = firstvec;
>  		}
> -- 
> 2.27.0
> 

-- 
Ming

Re: [PATCH v3] irq: consider cpus on nodes are unbalanced

[Rei Yamamoto]

On Thu, Feb 10, 2022 at 12:10:18PM +0800, Ming Lei wrote:
> On Thu, Feb 10, 2022 at 12:10:53PM +0900, Rei Yamamoto wrote:
>> If cpus on a node are offline at boot time, there are
>> difference in the number of nodes between when building affinity
>> masks for present cpus and when building affinity masks for possible
>> cpus. This patch fixes a problem caused by the difference of the
>> number of nodes:
>> 
>>  - The routine of "numvecs <= nodes" condition can overwrite bits of
>>    masks for present cpus in building masks for possible cpus. Fix this
>>    problem by making CPU bits, which is not target, not changing.
>> 
>> Signed-off-by: Rei Yamamoto <yamamoto.rei@jp.fujitsu.com>
>> Reviewed-by: Ming Lei <ming.lei@redhat.com>
>> ---
>>  kernel/irq/affinity.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git a/kernel/irq/affinity.c b/kernel/irq/affinity.c
>> index f7ff8919dc9b..d2d01565d2ec 100644
>> --- a/kernel/irq/affinity.c
>> +++ b/kernel/irq/affinity.c
>> @@ -269,8 +269,9 @@ static int __irq_build_affinity_masks(unsigned int startvec,
>>  	 */
>>  	if (numvecs <= nodes) {
>>  		for_each_node_mask(n, nodemsk) {
>> +			cpumask_and(nmsk, cpu_mask, node_to_cpumask[n]);
>>  			cpumask_or(&masks[curvec].mask, &masks[curvec].mask,
>> -				   node_to_cpumask[n]);
>> +				   nmsk);
>>  			if (++curvec == last_affv)
>>  				curvec = firstvec;
>>  		}
>> -- 
>> 2.27.0
>>
> -- 
> Ming

Could you pick this patch up?

Thanks,
Rei

Re: [PATCH v3] irq: consider cpus on nodes are unbalanced

[Thomas Gleixner]

On Wed, Mar 30 2022 at 13:42, Rei Yamamoto wrote:
> On Thu, Feb 10, 2022 at 12:10:18PM +0800, Ming Lei wrote:
>> On Thu, Feb 10, 2022 at 12:10:53PM +0900, Rei Yamamoto wrote:
>
> Could you pick this patch up?

Which patch? Whatever that patch is, it did neither arrive in my inbox
nor in a public archive:

    https://lore.kernel.org/all/20220210031053.5352-1-yamamoto.rei@jp.fujitsu.com/

Thanks,

        tglx

Re: [PATCH v3] irq: consider cpus on nodes are unbalanced

[Rei Yamamoto]

On Thu, Mar 31 2022 at 01:09:03 +0200 Thomas Gleixner wrote:
> On Wed, Mar 30 2022 at 13:42, Rei Yamamoto wrote:
>> On Thu, Feb 10, 2022 at 12:10:18PM +0800, Ming Lei wrote:
>>> On Thu, Feb 10, 2022 at 12:10:53PM +0900, Rei Yamamoto wrote:
>>
>> Could you pick this patch up?
>
> Which patch? Whatever that patch is, it did neither arrive in my inbox nor in a public archive:
>
>    https://lore.kernel.org/all/20220210031053.5352-1-yamamoto.rei@jp.fujitsu.com/

Certainly the patch did not seem to arrive.
I will send the patch ,which I want you to pick up, as v4.

Thanks, 
Rei