From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74713C433EF for ; Mon, 8 Nov 2021 10:56:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 57A3A6112D for ; Mon, 8 Nov 2021 10:56:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238886AbhKHK7g (ORCPT ); Mon, 8 Nov 2021 05:59:36 -0500 Received: from relay10.mail.gandi.net ([217.70.178.230]:58333 "EHLO relay10.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238859AbhKHK7U (ORCPT ); Mon, 8 Nov 2021 05:59:20 -0500 Received: (Authenticated sender: gregory.clement@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 4605D24000B; Mon, 8 Nov 2021 10:56:34 +0000 (UTC) From: Gregory CLEMENT To: Andy Shevchenko , Andy Shevchenko , Bartosz Golaszewski , Jianqun Xu , Linus Walleij , Sai Krishna Potthuri , Andrew Morton , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Cc: Bamvor Jian Zhang , Andrew Lunn , Sebastian Hesselbarth , Heiko Stuebner , Patrice Chotard , Michal Simek , Andy Shevchenko Subject: Re: [PATCH v1 10/19] pinctrl: armada-37xx: Make use of the devm_platform_ioremap_resource() In-Reply-To: <20211105124242.27288-10-andriy.shevchenko@linux.intel.com> References: <20211105124242.27288-1-andriy.shevchenko@linux.intel.com> <20211105124242.27288-10-andriy.shevchenko@linux.intel.com> Date: Mon, 08 Nov 2021 11:56:33 +0100 Message-ID: <87zgqesyou.fsf@BL-laptop> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Andy, > Use the devm_platform_ioremap_resource() helper instead of > calling of_address_to_resource() and devm_ioremap_resource() > separately. > > Signed-off-by: Andy Shevchenko Reviewed-by: Gregory CLEMENT Thanks, Gregory > --- > drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c > index 37f92dc54d7a..282b3fac3bec 100644 > --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c > +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c > @@ -727,7 +727,6 @@ static int armada_37xx_irqchip_register(struct platform_device *pdev, > struct gpio_irq_chip *girq = &gc->irq; > struct device *dev = &pdev->dev; > struct device_node *np; > - struct resource res; > int ret = -ENODEV, i, nr_irq_parent; > > /* Check if we have at least one gpio-controller child node */ > @@ -750,12 +749,7 @@ static int armada_37xx_irqchip_register(struct platform_device *pdev, > return 0; > } > > - if (of_address_to_resource(dev->of_node, 1, &res)) { > - dev_err(dev, "cannot find IO resource\n"); > - return -ENOENT; > - } > - > - info->base = devm_ioremap_resource(dev, &res); > + info->base = devm_platform_ioremap_resource(pdev, 1); > if (IS_ERR(info->base)) > return PTR_ERR(info->base); > > -- > 2.33.0 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com