Re: [PATCH v2] ARM: debug-ll: add default address for digicolor

Arnd Bergmann
2019-04-17T15:13:25Z

On Wed, Apr 17, 2019 at 4:18 PM Baruch Siach <baruch@tkos.co.il> wrote:
> On Wed, Apr 17 2019, Arnd Bergmann wrote:

> > diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> > index 6d6e0330930b..12c0d29b75e3 100644
> > --- a/arch/arm/Kconfig.debug
> > +++ b/arch/arm/Kconfig.debug
> > @@ -1677,6 +1677,7 @@ config DEBUG_UART_PHYS
> > default 0xe6ee0000 if DEBUG_RCAR_GEN2_SCIF4
> > default 0xe8008000 if DEBUG_R7S72100_SCIF2
> > default 0xf0000be0 if ARCH_EBSA110
> > + default 0xf0100000 if DEBUG_DIGICOLOR_UA0
>
> Should be 0xf0000000 for the physical address.
>
> > default 0xf1012000 if DEBUG_MVEBU_UART0_ALTERNATE
> > default 0xf1012100 if DEBUG_MVEBU_UART1_ALTERNATE
> > default 0xf7fc9000 if DEBUG_BERLIN_UART
> > @@ -1784,6 +1785,7 @@ config DEBUG_UART_VIRT
> > default 0xfd012000 if DEBUG_MVEBU_UART0_ALTERNATE && ARCH_MV78XX0
> > default 0xfd883000 if DEBUG_ALPINE_UART0
> > default 0xfde12000 if DEBUG_MVEBU_UART0_ALTERNATE && ARCH_DOVE
> > + default 0xfe000000 if DEBUG_DIGICOLOR_UA0
>
> Maybe you intended to change the virtual address to 0xf0100000?

Ouch, sorry for messing it up again. Sending a v3 now.

Arnd