From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C69EC282DA for ; Wed, 17 Apr 2019 02:05:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 199592177B for ; Wed, 17 Apr 2019 02:05:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=babayev.com header.i=@babayev.com header.b="BToFSUdG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729899AbfDQCFC (ORCPT ); Tue, 16 Apr 2019 22:05:02 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:33875 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727424AbfDQCFC (ORCPT ); Tue, 16 Apr 2019 22:05:02 -0400 Received: by mail-pg1-f193.google.com with SMTP id v12so11248902pgq.1 for ; Tue, 16 Apr 2019 19:05:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=babayev.com; s=google; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=DHgWX8BenTTHLAIhsHOcfwer3VhUji97XDm74Dz1U3I=; b=BToFSUdGYTU24GWhSNQ8aJwRmvHHUTDWahfHxafKU+iea7ZU/xbw1yALrSu0IeEWbZ Fcl12lCOOwxRvbaucutb/QXyEgFkUokX8yPUfm80rvFV3NvckORsC9Bj5yH59/IHLPM9 sfIK59cbauE+Q6M0VtEG/7UolhfbDs3wAffQ8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=DHgWX8BenTTHLAIhsHOcfwer3VhUji97XDm74Dz1U3I=; b=MK577A97eurYx9mP/1Wb6bhelWIM4VTVRlkNjEiR62W4DJcbqP4zTY4soOCClQMkHS 8sO9D4cp6PkMOfm+vDbSmpMsPEIiXg/jMWMb7L+T2W0oR3OfFdbH1GWOQsDlk8j4mTOp zuef98kJGYmUTm8d7/9PHqYk0ly/o6DpqMhLjzRDJCtzh+aAt3rqxHAWaBaFVLbZC74K CIPd58laci155B1Df5kQNpiEMsiKl/E9YwRhQYZFMYrU0tl2ix3/9i+MmS4ll5J5UPRe F5kqmBiLrtAUJRDfy0MqWEnzuOfC5NPNi9k/QlsnpYnBDF2lIr54oDMYS5Fh4w1rP92p 6jmw== X-Gm-Message-State: APjAAAUjr4kx64oESifkj5enzZYT5MSu4/CruuiXDOSdd+lnlTIADMN4 4A4nxPV6laS2dO8w/NKzDpl68A== X-Google-Smtp-Source: APXvYqx95duLpezI8vQsZevG2MTXhFBesevf2aH+BVMCN5Uzq4QaQNc9/K4q0o5UaHkzxOSPK8jLng== X-Received: by 2002:aa7:9294:: with SMTP id j20mr22851905pfa.64.1555466701410; Tue, 16 Apr 2019 19:05:01 -0700 (PDT) Received: from localhost (50-46-216-15.evrt.wa.frontiernet.net. [50.46.216.15]) by smtp.gmail.com with ESMTPSA id p128sm123265808pfp.30.2019.04.16.19.05.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 Apr 2019 19:05:00 -0700 (PDT) References: <20190416183620.39950-3-ruslan@babayev.com> <20190416201603.GA25257@roeck-us.net> User-agent: mu4e 1.0; emacs 26.1 From: Ruslan Babayev To: Guenter Roeck Cc: Ruslan Babayev , Jean Delvare , xe-linux-external@cisco.com, Jonathan Corbet , linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] hwmon: (pmbus) add support for IR35215 In-reply-to: <20190416201603.GA25257@roeck-us.net> Date: Tue, 16 Apr 2019 19:04:59 -0700 Message-ID: <87zhopcrp0.fsf@babayev.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Guenter Roeck writes: >> + >> +#include >> +#include >> +#include >> +#include >> +#include > > Alphabetic include file order please. Sure >> + >> +static struct pmbus_driver_info ir3570b_info = { >> + .pages = 1, > > Either this ... > >> + .format[PSC_VOLTAGE_IN] = linear, >> + .format[PSC_VOLTAGE_OUT] = linear, >> + .format[PSC_CURRENT_IN] = linear, >> + .format[PSC_CURRENT_OUT] = linear, >> + .format[PSC_POWER] = linear, >> + .format[PSC_TEMPERATURE] = linear, >> + .func[0] = IR3570B_FUNCS, >> + .func[1] = IR3570B_FUNCS, > > ... or this is wrong. The latter is wrong. Thanks for catching it.