Re: [PATCH v1 06/15] powerpc/Kconfig: select PPC_MM_SLICES from subarch type

Aneesh Kumar K.V
2019-04-11T05:07:43Z

Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com> writes:

> Christophe Leroy <christophe.leroy@c-s.fr> writes:
>
>> Lets select PPC_MM_SLICES from the subarch config item instead of
>> doing it via defaults declaration in the PPC_MM_SLICES item itself.
>>
>
> Did we miss the book3s 64 default y here?
>
>> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
>> ---
>> arch/powerpc/platforms/Kconfig.cputype | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype
>> index 842b2c7e156a..a46a0adb634d 100644
>> --- a/arch/powerpc/platforms/Kconfig.cputype
>> +++ b/arch/powerpc/platforms/Kconfig.cputype
>> @@ -34,6 +34,7 @@ config PPC_8xx
>> bool "Freescale 8xx"
>> select FSL_SOC
>> select SYS_SUPPORTS_HUGETLBFS
>> + select PPC_MM_SLICES if HUGETLB_PAGE
>>
>> config 40x
>> bool "AMCC 40x"
>> @@ -75,6 +76,7 @@ config PPC_BOOK3S_64
>> select ARCH_ENABLE_THP_MIGRATION if TRANSPARENT_HUGEPAGE
>> select ARCH_SUPPORTS_NUMA_BALANCING
>> select IRQ_WORK
>> + select PPC_MM_SLICES

ok this takes care of BOOK3S_64.

>>
>> config PPC_BOOK3E_64
>> bool "Embedded processors"
>> @@ -360,8 +362,6 @@ config PPC_BOOK3E_MMU
>>
>> config PPC_MM_SLICES
>> bool
>> - default y if PPC_BOOK3S_64
>> - default y if PPC_8xx && HUGETLB_PAGE
>>
>> config PPC_HAVE_PMU_SUPPORT
>> bool
>> --
>> 2.13.3