From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751974AbeBZQfy (ORCPT ); Mon, 26 Feb 2018 11:35:54 -0500 Received: from out01.mta.xmission.com ([166.70.13.231]:53706 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751795AbeBZQfv (ORCPT ); Mon, 26 Feb 2018 11:35:51 -0500 From: ebiederm@xmission.com (Eric W. Biederman) To: Miklos Szeredi Cc: lkml , Linux Containers , linux-fsdevel , Alban Crequy , Seth Forshee , Sargun Dhillon , Dongsu Park , "Serge E. Hallyn" References: <878tbmf5vl.fsf@xmission.com> <20180221202908.17258-4-ebiederm@xmission.com> <87inao6dfa.fsf@xmission.com> <87mv004p0t.fsf@xmission.com> Date: Mon, 26 Feb 2018 10:35:17 -0600 In-Reply-To: (Miklos Szeredi's message of "Mon, 26 Feb 2018 08:47:21 +0100") Message-ID: <87zi3v1zga.fsf@xmission.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1eqLki-0006Ye-63;;;mid=<87zi3v1zga.fsf@xmission.com>;;;hst=in01.mta.xmission.com;;;ip=174.19.85.160;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1/uP/E0WcKm8SPoYYRjJfuelyzkF/V9C2Y= X-SA-Exim-Connect-IP: 174.19.85.160 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.0 TVD_RCVD_IP Message was received from an IP address * 0.7 XMSubLong Long Subject * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.4988] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa03 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa03 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ;Miklos Szeredi X-Spam-Relay-Country: X-Spam-Timing: total 536 ms - load_scoreonly_sql: 0.08 (0.0%), signal_user_changed: 6 (1.2%), b_tie_ro: 2.2 (0.4%), parse: 3.2 (0.6%), extract_message_metadata: 36 (6.8%), get_uri_detail_list: 2.3 (0.4%), tests_pri_-1000: 18 (3.3%), tests_pri_-950: 2.9 (0.5%), tests_pri_-900: 2.3 (0.4%), tests_pri_-400: 38 (7.1%), check_bayes: 35 (6.5%), b_tokenize: 12 (2.3%), b_tok_get_all: 7 (1.4%), b_comp_prob: 4.6 (0.9%), b_tok_touch_all: 4.5 (0.8%), b_finish: 2.5 (0.5%), tests_pri_0: 389 (72.6%), check_dkim_signature: 1.42 (0.3%), check_dkim_adsp: 6 (1.2%), tests_pri_500: 14 (2.6%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH v6 4/5] fuse: Ensure posix acls are translated outside of init_user_ns X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Miklos Szeredi writes: > On Thu, Feb 22, 2018 at 11:50 PM, Eric W. Biederman > wrote: > >> So if we could figure out how to use the generic acl support for the old >> brand of fuse filesystems that don't set FUSE_POSIX_ACL it would be much >> easier to support them long term. > > Simplest and most robust way seems to be to do everything the same (as > with FUSE_POSIX_ACL) but tell the vfs not to cache the acl. Good point. That sounds like for the !fc->posix_acl case we just need a careful use of "forget_all_cached_acls(inode)". I will take a quick look at that, and see if that is easy/sufficient to cover the legacy fuse case. Otherwise I will go with what I already have here. That feels like a better path. And internally I would call what is today fc->posix_acl fc->cached_posix_acl. To better convey the intent. Fingers crossed. Eric