From: Nicolai Stange <nicstange@gmail.com>
To: "Mika Penttilä" <mika.penttila@nextfour.com>
Cc: Nicolai Stange <nicstange@gmail.com>,
Matt Fleming <matt@codeblueprint.co.uk>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
<x86@kernel.org>, <linux-efi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] efi: efi_mem_reserve(): don't reserve through memblock after mm_init()
Date: Thu, 22 Dec 2016 11:26:36 +0100 [thread overview]
Message-ID: <87zijoz2cj.fsf@gmail.com> (raw)
In-Reply-To: <c7bf34ba-56f0-8346-36d1-7069f2115dcf@nextfour.com> ("Mika \=\?utf-8\?Q\?Penttil\=C3\=A4\=22's\?\= message of "Wed, 21 Dec 2016 20:45:13 +0200")
Mika Penttilä <mika.penttila@nextfour.com> writes:
> On 21.12.2016 20:28, Nicolai Stange wrote:
>> /**
>> * efi_mem_reserve - Reserve an EFI memory region
>> @@ -419,7 +422,7 @@ void __init __weak efi_arch_mem_reserve(phys_addr_t addr, u64 size) {}
>> */
>> void __init efi_mem_reserve(phys_addr_t addr, u64 size)
>> {
>> - if (!memblock_is_region_reserved(addr, size))
>> + if (slab_is_available() && !memblock_is_region_reserved(addr, size))
>> memblock_reserve(addr, size);
> Maybe !slab_is_available() ?
You're right, thanks for catching this!
Fixed in v2 at http://lkml.kernel.org/r/20161222102340.2689-2-nicstange@gmail.com
Thanks,
Nicolai
prev parent reply other threads:[~2016-12-22 10:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-21 18:28 [PATCH 1/2] x86/efi: don't allocate memmap through memblock after mm_init() Nicolai Stange
2016-12-21 18:28 ` [PATCH 2/2] efi: efi_mem_reserve(): don't reserve " Nicolai Stange
2016-12-21 18:45 ` Mika Penttilä
2016-12-22 10:26 ` Nicolai Stange [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zijoz2cj.fsf@gmail.com \
--to=nicstange@gmail.com \
--cc=ard.biesheuvel@linaro.org \
--cc=hpa@zytor.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mika.penttila@nextfour.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox