From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754063AbcHRNwY (ORCPT ); Thu, 18 Aug 2016 09:52:24 -0400 Received: from mga14.intel.com ([192.55.52.115]:45348 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752585AbcHRNwX (ORCPT ); Thu, 18 Aug 2016 09:52:23 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,539,1464678000"; d="asc'?scan'208";a="1027698435" From: Felipe Balbi To: Javier Martinez Canillas , linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas , Greg Kroah-Hartman , linux-usb@vger.kernel.org Subject: Re: [PATCH 2/3] usb: gadget: use IS_ENABLED() instead of checking for built-in or module In-Reply-To: <1471527906-16604-2-git-send-email-javier@osg.samsung.com> References: <1471527906-16604-1-git-send-email-javier@osg.samsung.com> <1471527906-16604-2-git-send-email-javier@osg.samsung.com> User-Agent: Notmuch/0.22.1+63~g994277e (https://notmuchmail.org) Emacs/25.1.1 (x86_64-pc-linux-gnu) Date: Thu, 18 Aug 2016 16:49:03 +0300 Message-ID: <87zioa2nn4.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Javier Martinez Canillas writes: > The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either > built-in or as a module, use that macro instead of open coding the same. > > Using the macro makes the code more readable by helping abstract away some > of the Kconfig built-in and module enable details. > > Signed-off-by: Javier Martinez Canillas Acked-by: Felipe Balbi > --- > > drivers/usb/gadget/udc/omap_udc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/udc/omap_udc.c b/drivers/usb/gadget/udc/o= map_udc.c > index 9b7d39484ed3..a8709f9e5648 100644 > --- a/drivers/usb/gadget/udc/omap_udc.c > +++ b/drivers/usb/gadget/udc/omap_udc.c > @@ -2875,7 +2875,7 @@ bad_on_1710: > xceiv =3D NULL; > /* "udc" is now valid */ > pullup_disable(udc); > -#if defined(CONFIG_USB_OHCI_HCD) || defined(CONFIG_USB_OHCI_HCD_MODULE) > +#if IS_ENABLED(CONFIG_USB_OHCI_HCD) > udc->gadget.is_otg =3D (config->otg !=3D 0); > #endif >=20=20 > --=20 > 2.5.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJXtbzPAAoJEIaOsuA1yqREJiIP+gNH0dXKWWkwS5ABiQL3UJQP Tt6AUl1eaYn/dRhHQvb2fqdFFwCvukZOo/+egc/fx0uWWWq/itz4tPApB6we+1dQ bhXIBkUVVnhbu0hqxiEwHUmcyT9ASjiCcBAmn9zcuqqgOCos3fKGe7hz/3hyJbay KhWXo0NIeB3luROSpZZNNEHoOyOi+0Lw+pRSIdIRJsZZ/ewBOE8fpmgrjnadH7OY sX8JeYc+FsdBGhL87Nt4PXixBaBxXkc1aeLJ8fTnUCxB70DppitN/VNAh4NRq6bO PUuyTVGaaoAuOS2y94B9AFKPyuHzvZ+HGI+T7YBxm7nL9eBADiRKAsu3VFY3AcTh ORoDjB1RaB+WOStYcGhdVwVU4s8ohhlFyr3x1MqOL7Vk2xrLqUzRFli5p8BxZBiY DQNuBGM8sBJBIWJS3adjLm6OodKYcqPLLFW/qyCsVDptqfoYxlsr/FtoySpVnPNx 3e3IDE+UF8ulUaCmdLgVDIBLt0rL9cBSbuYWqYtdwBliL7Hcs54jgun7akhvl/KN kyJfKVrBYoXk71SO5P7dGCvmZMpdEMN4gyBGeDu5j6NiLrausdwpN1KHJGY/QCAx F70b8LjfsXljni2FzlDt+2IIJCgFLe8WpA0A+DaD5/I6iS1kB4E5M/dMbSjyTRAk IVNwEjAcX7SAc/WXODz4 =4kl5 -----END PGP SIGNATURE----- --=-=-=--