Re: [PATCH 1/4] arm64: dts: marvell: Clean up armada-3720-db

Gregory CLEMENT
2016-03-24T16:12:08Z

Hi Andreas,

On mer., mars 23 2016, Andreas Färber <afaerber@suse.de> wrote:

> Instead of duplicating the SoC's node hierarchy, including a bus node
> named "internal-regs", reference the actually desired nodes by label,
> like Berlin already does. Add labels where necessary.

We talked about this for the 3rd patch, but the conclusion will apply
here too. So we are going to use this solution for the mvebu 64bits. I
have just a minor remark.

>
> Drop an inconsistent white line while at it.
>
> Fixes: adbc3695d9e4 ("arm64: dts: add the Marvell Armada 3700 family and a development board")
> Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
> arch/arm64/boot/dts/marvell/armada-3720-db.dts | 35 +++++++++++---------------
> arch/arm64/boot/dts/marvell/armada-372x.dtsi | 1 -
> arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 4 +--
> 3 files changed, 17 insertions(+), 23 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-db.dts b/arch/arm64/boot/dts/marvell/armada-3720-db.dts
> index 359050154511..48f97d14b057 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-db.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-db.dts
> @@ -60,27 +60,22 @@
> device_type = "memory";
> reg = <0x00000000 0x00000000 0x00000000 0x20000000>;
> };
> +};
>
> - soc {
> - internal-regs {
> - /*
> - * Exported on the micro USB connector CON32
> - * through an FTDI
> - */
> - uart0: serial@12000 {
> - status = "okay";
> - };
> -
> - /* CON31 */
> - usb3@58000 {
> - status = "okay";
> - };
> +/* CON3 */
> +&sata {
> + status = "okay";
> +};
>
> - /* CON3 */
> - sata@e0000 {
> - status = "okay";
> - };
> - };
> - };
> +/*
> + * Exported on the micro USB connector CON32
> + * through an FTDI
> + */

As the comment didn't start anymore from the middle of the line, we
could have it an a single line. We don't have to split in 2 lines.

Thanks,

Gregory

--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.