From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752937AbbKXIsS (ORCPT ); Tue, 24 Nov 2015 03:48:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52319 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752243AbbKXIsR (ORCPT ); Tue, 24 Nov 2015 03:48:17 -0500 From: Vitaly Kuznetsov To: "K. Y. Srinivasan" Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, jasowang@redhat.com Subject: Re: [PATCH net-next 01/10] hv_netvsc: Resize some of the variables in hv_netvsc_packet References: <1448321324-21318-1-git-send-email-kys@microsoft.com> <1448321346-21357-1-git-send-email-kys@microsoft.com> Date: Tue, 24 Nov 2015 09:48:12 +0100 In-Reply-To: <1448321346-21357-1-git-send-email-kys@microsoft.com> (K. Y. Srinivasan's message of "Mon, 23 Nov 2015 15:28:57 -0800") Message-ID: <87ziy3lr5f.fsf@vitty.brq.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "K. Y. Srinivasan" writes: > As part of reducing the size of the hv_netvsc_packet, resize some of the > variables based on their usage. > > Signed-off-by: K. Y. Srinivasan > Reviewed-by: Haiyang Zhang > --- > drivers/net/hyperv/hyperv_net.h | 14 +++++++------- > 1 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net/hyperv/hyperv_net.h > index 5fa98f5..972e562 100644 > --- a/drivers/net/hyperv/hyperv_net.h > +++ b/drivers/net/hyperv/hyperv_net.h > @@ -127,11 +127,11 @@ struct ndis_tcp_ip_checksum_info; > */ > struct hv_netvsc_packet { > /* Bookkeeping stuff */ > - u32 status; > + u8 status; > > - bool is_data_pkt; > - bool xmit_more; /* from skb */ > - bool cp_partial; /* partial copy into send buffer */ > + u8 is_data_pkt; > + u8 xmit_more; /* from skb */ > + u8 cp_partial; /* partial copy into send buffer */ These are flags so we can make them bitfields and save even more space. > > u16 vlan_tci; > > @@ -147,13 +147,13 @@ struct hv_netvsc_packet { > /* This points to the memory after page_buf */ > struct rndis_message *rndis_msg; > > - u32 rmsg_size; /* RNDIS header and PPI size */ > - u32 rmsg_pgcnt; /* page count of RNDIS header and PPI */ > + u8 rmsg_size; /* RNDIS header and PPI size */ > + u8 rmsg_pgcnt; /* page count of RNDIS header and PPI */ > > u32 total_data_buflen; > /* Points to the send/receive buffer where the ethernet frame is */ > void *data; > - u32 page_buf_cnt; > + u8 page_buf_cnt; > struct hv_page_buffer *page_buf; > }; -- Vitaly