From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753449AbbCLKxi (ORCPT ); Thu, 12 Mar 2015 06:53:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54801 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753068AbbCLKxf (ORCPT ); Thu, 12 Mar 2015 06:53:35 -0400 From: Vitaly Kuznetsov To: Olaf Hering Cc: "K. Y. Srinivasan" , gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, apw@canonical.com Subject: Re: [PATCH 2/6] Drivers: hv: hv_balloon: keep locks balanced on add_memory() failure References: <1426125345-12530-1-git-send-email-kys@microsoft.com> <1426125419-12571-1-git-send-email-kys@microsoft.com> <1426125419-12571-2-git-send-email-kys@microsoft.com> <20150312104543.GB11353@aepfle.de> Date: Thu, 12 Mar 2015 11:53:22 +0100 In-Reply-To: <20150312104543.GB11353@aepfle.de> (Olaf Hering's message of "Thu, 12 Mar 2015 11:45:43 +0100") Message-ID: <87zj7isd0d.fsf@vitty.brq.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Olaf Hering writes: > On Wed, Mar 11, K. Y. Srinivasan wrote: > >> +++ b/drivers/hv/hv_balloon.c >> @@ -652,6 +652,7 @@ static void hv_mem_hot_add(unsigned long start, unsigned long size, >> } >> has->ha_end_pfn -= HA_CHUNK; >> has->covered_end_pfn -= processed_pfn; >> + mutex_lock(&dm_device.ha_region_mutex); >> break; >> } > > Should it call the wrapper instead of doing mutex_lock directly? > Like 'acquire_region_mutex(false);'. My "Drivers: hv: hv_balloon: eliminate the trylock path in acquire/release_region_mutex" (b05d8d9ef5ef21d1b18440430f950304836e1aaa in char-misc-next) removed these wrappers. > > Olaf -- Vitaly