Re: [PATCH 2/6] Drivers: hv: hv_balloon: keep locks balanced on add_memory() failure

Dan Carpenter
2015-03-12T11:41:22Z

On Thu, Mar 12, 2015 at 12:14:28PM +0100, Olaf Hering wrote:
> On Thu, Mar 12, Vitaly Kuznetsov wrote:
>
> > My "Drivers: hv: hv_balloon: eliminate the trylock path in
> > acquire/release_region_mutex" (b05d8d9ef5ef21d1b18440430f950304836e1aaa
> > in char-misc-next) removed these wrappers.
>
> I see now. There are many changes in char-misc-next. The description
> gives the impression that mainline is broken. Not sure if thats true,
> perhaps its just char-misc-next which is affected.

Mainline is broken. We only found these when we removed the wrapper and
then static checkers were able to catch the bug.

regards,
dan carpenter