From: Rusty Russell <rusty@rustcorp.com.au>
To: Sergei Ianovich <ynvich@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: "Elliott\, Robert \(Server Storage\)" <Elliott@hp.com>,
"ynvich\@gmail.com" <ynvich@gmail.com>,
"Lucas De Marchi" <lucas.de.marchi@gmail.com>
Subject: Re: [PATCH v2] fix printk output
Date: Wed, 23 Apr 2014 14:44:58 +0930 [thread overview]
Message-ID: <87zjjcfwz1.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1386660574.7152.203.camel@host5.omatika.ru>
Sergei Ianovich <ynvich@gmail.com> writes:
> On Tue, 2013-12-10 at 15:59 +1030, Rusty Russell wrote:
>> BTW, did you actually hit this?
>
> # modprobe usb_storage
> [ 600.807274] usbcore: registered new interface driver usb-storage
> # modprobe -r usb_storage
> [ 604.216318] waiting module removal not supported: please upgrade[
> 604.222164] usbcore: deregistering interface driver usb-storage
> # modprobe -V
> kmod version 9
>
> I am using the latest kmod package from emdebian unstable-grip.
Sorry, was off on leave.
Hmm, Lucas intimated that kmod version 11 started passing this flag
correctly.
In fact, kmod's modprobe *never* used the O_NONBLOCK
(ie. KMOD_REMOVE_NOWAIT) flag, until it was finally enforced in
commit 7ab8804448377fb6b8854f2dd288608db01bb43b
Author: Lucas De Marchi <lucas.demarchi@intel.com>
Date: Fri Sep 20 01:30:07 2013 -0500
See: tools/modprobe.c at that commit:
static int rmmod_do_remove_module(struct kmod_module *mod)
{
const char *modname = kmod_module_get_name(mod);
struct kmod_list *deps, *itr;
int flags = 0, err;
...
if (force)
flags |= KMOD_REMOVE_FORCE;
err = kmod_module_remove_module(mod, flags);
Perhaps we need to just get rid of the kernel message, since we're
getting far too many false reports :(
Cheers,
Rusty.
next prev parent reply other threads:[~2014-04-23 5:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 22:03 [PATCH] fix printk output Sergei Ianovich
2013-11-27 22:07 ` Hannes Frederic Sowa
2013-11-30 15:42 ` [PATCH v2] " Sergei Ianovich
2013-12-10 5:29 ` Rusty Russell
2013-12-10 7:29 ` Sergei Ianovich
2014-04-23 5:14 ` Rusty Russell [this message]
2014-04-23 9:50 ` Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zjjcfwz1.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=hannes@stressinduktion.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ynvich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox