Re: [PATCH 10/33] perf, tools: Add abort,notx,intx branch filter options to perf report -j v2

[Namhyung Kim <namhyung@kernel.org>]

Just minor nitpicks..


On Fri, 26 Oct 2012 13:29:52 -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> Make perf report -j aware of the new intx,notx,abort branch qualifiers.

s/report/record/

The same goes to the subject line too.

>
> v2: ABORT -> ABORTTX
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
>  tools/perf/Documentation/perf-record.txt |    3 +++
>  tools/perf/builtin-record.c              |    3 +++
>  2 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt
> index b38a1f9..4b9f477 100644
> --- a/tools/perf/Documentation/perf-record.txt
> +++ b/tools/perf/Documentation/perf-record.txt
> @@ -172,6 +172,9 @@ following filters are defined:
>          - u:  only when the branch target is at the user level
>          - k: only when the branch target is in the kernel
>          - hv: only when the target is at the hypervisor level
> +	- intx: only when the target is in a hardware transaction
> +	- notx: only when the target is not in a hardware transaction
> +	- aborttx: only when the target is a hardware transaction abort

Mixed tabs and spaces for indentation.


>  
>  +
>  The option requires at least one branch type among any, any_call, any_ret, ind_call.
> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> index e9231659..88ecbbd 100644
> --- a/tools/perf/builtin-record.c
> +++ b/tools/perf/builtin-record.c
> @@ -725,6 +725,9 @@ static const struct branch_mode branch_modes[] = {
>  	BRANCH_OPT("any_call", PERF_SAMPLE_BRANCH_ANY_CALL),
>  	BRANCH_OPT("any_ret", PERF_SAMPLE_BRANCH_ANY_RETURN),
>  	BRANCH_OPT("ind_call", PERF_SAMPLE_BRANCH_IND_CALL),
> +	BRANCH_OPT("aborttx", PERF_SAMPLE_BRANCH_ABORTTX),
> +	BRANCH_OPT("intx", PERF_SAMPLE_BRANCH_INTX),
> +	BRANCH_OPT("notx", PERF_SAMPLE_BRANCH_NOTX),

How about make them abort_tx, in_tx and no_tx?  I often read them like
int_x and not_x. ;)

Thanks,
Namhyung


>  	BRANCH_END
>  };