From: Rusty Russell <rusty@rustcorp.com.au>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: Felipe Balbi <balbi@ti.com>,
trivial@kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] trivial: treewide: remove extra semicolon added by module_init/exit
Date: Tue, 12 Jun 2012 09:56:36 +0930 [thread overview]
Message-ID: <87zk89nznn.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20120611142028.380c5a61@nehalam.linuxnetplumber.net>
On Mon, 11 Jun 2012 14:20:28 -0700, Stephen Hemminger <shemminger@vyatta.com> wrote:
> Given common kernel practice and the fact that only 16% of the uses of
> module_init/exit are without semicolon and that other kernel macros don't
> include semicolon.
>
> I recommend going with the majority and common practice...
> 1. Fix the 636 places that use module_init()/exit without semicolon to include semicolon
> 2. Remove semicolon from module_init()/exit()
Um, yes. He should do exactly what he did.
It's a wart, let's fix it.
Thanks,
Rusty.
PS. CC's chopped; somewhere in there is a bad address...
next prev parent reply other threads:[~2012-06-12 9:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1338990069-6627-1-git-send-email-balbi@ti.com>
2012-06-10 12:39 ` [PATCH] trivial: treewide: remove extra semicolon added by module_init/exit Nicolas Ferre
[not found] ` <20120606083119.0d0a0029@nehalam.linuxnetplumber.net>
[not found] ` <87zk8bhfds.fsf@rustcorp.com.au>
[not found] ` <20120611142028.380c5a61@nehalam.linuxnetplumber.net>
2012-06-12 0:26 ` Rusty Russell [this message]
2012-06-12 9:43 ` Felipe Balbi
2012-06-12 9:47 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zk89nznn.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=balbi@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox