[PATCH] fs/fat: fix build warning

[PATCH] fs/fat: fix build warning

[Linus Walleij]

From: Jonas Aberg <jonas.aberg@stericsson.com>

This fixes a compile warning (unititialized variable) in
the fat filesystem code.

Signed-off-by: Jonas Aberg <jonas.aberg@stericsson.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 fs/fat/dir.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/fat/dir.c b/fs/fat/dir.c
index ee42b9e..aace9be 100644
--- a/fs/fat/dir.c
+++ b/fs/fat/dir.c
@@ -1229,7 +1229,7 @@ int fat_add_entries(struct inode *dir, void *slots, int nr_slots,
 	struct super_block *sb = dir->i_sb;
 	struct msdos_sb_info *sbi = MSDOS_SB(sb);
 	struct buffer_head *bh, *prev, *bhs[3]; /* 32*slots (672bytes) */
-	struct msdos_dir_entry *de;
+	struct msdos_dir_entry *de = NULL;
 	int err, free_slots, i, nr_bhs;
 	loff_t pos, i_pos;
 
-- 
1.7.3.2

Re: [PATCH] fs/fat: fix build warning

[OGAWA Hirofumi]

Linus Walleij <linus.walleij@stericsson.com> writes:

> From: Jonas Aberg <jonas.aberg@stericsson.com>
>
> This fixes a compile warning (unititialized variable) in
> the fat filesystem code.
>
> Signed-off-by: Jonas Aberg <jonas.aberg@stericsson.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  fs/fat/dir.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/fat/dir.c b/fs/fat/dir.c
> index ee42b9e..aace9be 100644
> --- a/fs/fat/dir.c
> +++ b/fs/fat/dir.c
> @@ -1229,7 +1229,7 @@ int fat_add_entries(struct inode *dir, void *slots, int nr_slots,
>  	struct super_block *sb = dir->i_sb;
>  	struct msdos_sb_info *sbi = MSDOS_SB(sb);
>  	struct buffer_head *bh, *prev, *bhs[3]; /* 32*slots (672bytes) */
> -	struct msdos_dir_entry *de;
> +	struct msdos_dir_entry *de = NULL;
>  	int err, free_slots, i, nr_bhs;
>  	loff_t pos, i_pos;

	struct msdos_dir_entry *uninitialized_var(de);

IIRC, x86 gcc doesn't warn it. Does uninitialized_var(de) make your gcc
version silent? If so, I'd like to change it like this.

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

[PATCH] fs/fat: fix build warning

[Linus Walleij]

From: Jonas Aberg <jonas.aberg@stericsson.com>

This fixes a compile warning (unititialized variable) in
the fat filesystem code.

Signed-off-by: Jonas Aberg <jonas.aberg@stericsson.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
v2: use uninitialized_var() macro, this is verified to work with
static code-checking tools.
---
 fs/fat/dir.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/fat/dir.c b/fs/fat/dir.c
index 4ad6473..5efbd5d 100644
--- a/fs/fat/dir.c
+++ b/fs/fat/dir.c
@@ -1231,7 +1231,7 @@ int fat_add_entries(struct inode *dir, void *slots, int nr_slots,
 	struct super_block *sb = dir->i_sb;
 	struct msdos_sb_info *sbi = MSDOS_SB(sb);
 	struct buffer_head *bh, *prev, *bhs[3]; /* 32*slots (672bytes) */
-	struct msdos_dir_entry *de;
+	struct msdos_dir_entry *uninitialized_var(de);
 	int err, free_slots, i, nr_bhs;
 	loff_t pos, i_pos;
 
-- 
1.7.3.2

Re: [PATCH] fs/fat: fix build warning

[OGAWA Hirofumi]

Linus Walleij <linus.walleij@stericsson.com> writes:

> From: Jonas Aberg <jonas.aberg@stericsson.com>
>
> This fixes a compile warning (unititialized variable) in
> the fat filesystem code.

Thanks. I'll apply.

> Signed-off-by: Jonas Aberg <jonas.aberg@stericsson.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> v2: use uninitialized_var() macro, this is verified to work with
> static code-checking tools.
> ---
>  fs/fat/dir.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/fat/dir.c b/fs/fat/dir.c
> index 4ad6473..5efbd5d 100644
> --- a/fs/fat/dir.c
> +++ b/fs/fat/dir.c
> @@ -1231,7 +1231,7 @@ int fat_add_entries(struct inode *dir, void *slots, int nr_slots,
>  	struct super_block *sb = dir->i_sb;
>  	struct msdos_sb_info *sbi = MSDOS_SB(sb);
>  	struct buffer_head *bh, *prev, *bhs[3]; /* 32*slots (672bytes) */
> -	struct msdos_dir_entry *de;
> +	struct msdos_dir_entry *uninitialized_var(de);
>  	int err, free_slots, i, nr_bhs;
>  	loff_t pos, i_pos;

-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

Re: [PATCH] fs/fat: fix build warning

[Linus Walleij]

2011/6/8 OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>:

> Linus Walleij <linus.walleij@stericsson.com> writes:
>
>> From: Jonas Aberg <jonas.aberg@stericsson.com>
>>
>> This fixes a compile warning (unititialized variable) in
>> the fat filesystem code.
>
> Thanks. I'll apply.

Hirofumi, I cannot see this fix in the mainline kernel as of v3.1-rc1.
Has it slipped out?

Thanks,
Linus Walleij