From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Karel Zak <kzak@redhat.com>
Cc: linux-kernel@vger.kernel.org, t.artem@mailcity.com,
Roman Zippel <zippel@linux-m68k.org>
Subject: Re: MS_SILENT vs. vfat and hfs
Date: Thu, 03 Mar 2011 00:13:54 +0900 [thread overview]
Message-ID: <87zkpdpnbh.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <20110302144303.GC14636@nb.net.home> (Karel Zak's message of "Wed, 2 Mar 2011 15:43:03 +0100")
Karel Zak <kzak@redhat.com> writes:
> On Wed, Mar 02, 2011 at 11:14:28PM +0900, OGAWA Hirofumi wrote:
>> Karel Zak <kzak@redhat.com> writes:
>>
>> > The mount(8) command uses "quiet" mount option as a synonym to the
>> > MS_SILENT mount flag (since util-linux 2.7, Aug 1997).
>> >
>> > It means than on systems where is properly defined the MS_SILENT
>> > mount flags in headers is the "quiet" mount option always translated
>> > to the MS_SILENT mount flags and "quiet" string is never send to FS
>> > drivers.
>> >
>> > $ strace -e mount mount -o quiet /dev/sdb1 /mnt/test
>> > mount("/dev/sdb1", "/mnt/test", "vfat", MS_MGC_VAL|MS_SILENT, NULL) = 0
>> > ^^^^^^^^^
>> >
>> > Unfortunately,
>> >
>> > $ grep -r \"quiet\" *
>> >
>> > fat/inode.c: {Opt_quiet, "quiet"},
>> > hfs/super.c: { opt_quiet, "quiet" },
>> >
>> > vfat and hfs drivers use "quiet" as a mount option. That's bug.
>> >
>> > There should not be a collision between mount(8) mount options and
>> > filesystem specific mount options.
>> >
>> > My suggestion is to fix the fat and hfs code to use something other
>> > than "quiet" (shutup, noisless, ...). I think you don't have to care
>> > about backward compatibility, because it's probably broken for years.
>>
>> No. Actually the _new_ option is MS_SILENT. In history, there was no
>> MS_SILENT (it was called MS_VERBOSE) in kernel, then _added_ newly, and
>> never be enabled MS_SILENT in mount command until that.
>
> I know, but I don't care which option is newer. I'd like to found a
> solution with minimal impact to users.
Sounds good.
>> So, my suggestion is use "silent" (or something) as MS_SILENT for
>> backward compatibility. Because the "quiet" is already hardcoded by some
>> userland apps for vfat.
>
> Then all people who use "quiet" in their fstab will see problems...
I don't know how to know the minimal impact though. I'll bet to change
MS_SILENT, because at least the mount command in debian/testing doesn't
provide "quiet" as MS_SILENT.
Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
prev parent reply other threads:[~2011-03-02 15:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 11:45 MS_SILENT vs. vfat and hfs Karel Zak
2011-03-02 14:14 ` OGAWA Hirofumi
2011-03-02 14:43 ` Karel Zak
2011-03-02 15:06 ` Karel Zak
2011-03-02 15:16 ` OGAWA Hirofumi
2011-03-02 15:13 ` OGAWA Hirofumi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zkpdpnbh.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=kzak@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=t.artem@mailcity.com \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox