From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1759128AbZEKUrz@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1759128AbZEKUrz (ORCPT <rfc822;w@1wt.eu>);
	Mon, 11 May 2009 16:47:55 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755614AbZEKUrq
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Mon, 11 May 2009 16:47:46 -0400
Received: from mail-fx0-f158.google.com ([209.85.220.158]:56508 "EHLO
	mail-fx0-f158.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754487AbZEKUrp (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 11 May 2009 16:47:45 -0400
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:message-id:from:to:cc:subject:in-reply-to:references
         :user-agent:mime-version:content-type;
        b=KdTW/rzKyxtIp++hMJo3tSw4M7N0b+ecOvjP5qF3+x8gT3yzY/gihzmZAH9TgdNWJJ
         NSPRh4YTXrDtCFru79NvTGhHR3I6ZXPfPevmCTE3DXuSA0AkureFaircnJufAHWSZJS0
         0O/9x1fdhCUykF6yndkLqcXJGssl1vPMDU2po=
Date: Mon, 11 May 2009 22:47:43 +0200
Message-ID: <87zldjwemo.wl%vmayatsk@redhat.com>
From: Vitaly Mayatskikh <v.mayatskih@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Christoph Hellwig <hch@infradead.org>,
       Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>,
       Vitaly Mayatskikh <v.mayatskih@gmail.com>,
       Andrew Morton <akpm@linux-foundation.org>,
       Oleg Nesterov <oleg@redhat.com>, Roland McGrath <roland@redhat.com>,
       linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
       Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 1/5] Split wait_noreap_copyout()
In-Reply-To: <20090511121708.GD13954@elte.hu>
References: <1242036759-4025-1-git-send-email-v.mayatskih@gmail.com>
	<1242036759-4025-2-git-send-email-v.mayatskih@gmail.com>
	<20090511120418.GA3859@infradead.org>
	<20090511121708.GD13954@elte.hu>
User-Agent: Wanderlust/2.15.6 (Almost Unreal) Emacs/22.3 Mule/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Mon, 11 May 2009 14:17:08 +0200, Ingo Molnar wrote:

> > 	if (put_user(signal, &infop->si_signo) ||
> > 	    put_user(0, &infop->si_errno) ||
> > 	    put_user((short)why, &infop->si_code) ||
> > 	    put_user(pid, &infop->si_pid) ||
> > 	    put_user(uid, &infop->si_uid) ||
> > 	    put_user(status, &infop->si_status))
> > 		return -EFAULT;
> 
> For best assembly code this should generally be written as a series 
> of:
> 
>    __uaccess_err |= __put_user(x, ptr);
>    __uaccess_err |= __put_user(y, ptr);
>    __uaccess_err |= __put_user(z, ptr);
> 
> As this generates non-dependent, compressed, branch-less code.

Yeah, my first intention was to eliminate a lot of branches in one
place. It's terrible for CPU pipeline, I bet.

> See the (new) put_user_try / put_user_ex() / put_user_catch() 
> abstraction in arch/x86/include/asm/uaccess.h, and how all the x86 
> signal code makes use of that to optimize such patterns of per field 
> user copies.

So, there's catch block to handle GPF and the code inside of `try'
block is still branch-less, right? I was thinking of minimized version
of struct siginfo (up to si_uid) and copying it with single
copy_to_user(), but the idea with try/catch is definitely much
better.

-- 
wbr, Vitaly