GIT commit description flag(s)

GIT commit description flag(s)

[Artem S. Tashkinov]

It would be nice if [kernel] git commits had a flag [a char] (or a 
combination of) describing their main purpose which could be the following:

bug Fix [F]
Speed up/Performance [S]
Revert [R]
New functionality [N]

etc.

So a particular commit at 
http://git.kernel.org/?p=linux%2Fkernel%2Fgit%2Ftorvalds%2Flinux-2.6.git;a=summary

will look like:

19 hours ago 	Ingo Molnar 	sched: fix fair sleepers 	[F] commit | 
commitdiff | tree | snapshot

This way it will be much easier to keep track of important changes 
happening to the kernel.


--

Thanks for your attention,

Artem S. Tashkinov

Re: GIT commit description flag(s)

[Johannes Weiner]

Hi,

"Artem S. Tashkinov" <birdie@permonline.ru> writes:

> It would be nice if [kernel] git commits had a flag [a char] (or a
> combination of) describing their main purpose which could be the
> following:
>
> bug Fix [F]
> Speed up/Performance [S]
> Revert [R]
> New functionality [N]

> This way it will be much easier to keep track of important changes
> happening to the kernel.

You claim there are unimportant ones? :)

	Hannes

Re: GIT commit description flag(s)

[Jan Engelhardt]

On Mar 16 2008 02:35, Artem S. Tashkinov wrote:
> It would be nice if [kernel] git commits had a flag [a char] (or a combination 
> of) describing their main purpose which could be the following:
>
> bug Fix [F]
> Speed up/Performance [S]
> Revert [R]
> New functionality [N]

Usually you already give the type implicitly in the commit:

dfd347f... HID: fix comment in hid_input_report()
fa331ff... [S390] sclp_vt220: speed up console output for interactive work
d9452e9... [NETPOLL]: Revert two bogus cleanups that broke netconsole.
8727e28... m68k{,nommu}: Wire up new timerfd syscalls
b863ceb... [NET]: Add macvlan driver

So all is well.

Re: GIT commit description flag(s)

[Artem S. Tashkinov]

I quite agree with you that the description is already there, but such 
flags could help easily review or grep commits in order to identify your 
areas of interest.

Even your example has ambiguity: "Wire up new timerfd syscalls" - It's 
not easy to understand whether this particular commit is a bugfix, or it 
speeds up things, or the old code which has been cleaned up, etc.

Jan Engelhardt wrote:
>
> On Mar 16 2008 02:35, Artem S. Tashkinov wrote:
>> It would be nice if [kernel] git commits had a flag [a char] (or a
>> combination of) describing their main purpose which could be the
>> following:
>>
>> bug Fix [F]
>> Speed up/Performance [S]
>> Revert [R]
>> New functionality [N]
>
> Usually you already give the type implicitly in the commit:
>
> dfd347f... HID: fix comment in hid_input_report()
> fa331ff... [S390] sclp_vt220: speed up console output for interactive work
> d9452e9... [NETPOLL]: Revert two bogus cleanups that broke netconsole.
> 8727e28... m68k{,nommu}: Wire up new timerfd syscalls
> b863ceb... [NET]: Add macvlan driver
>
> So all is well.
>

Re: GIT commit description flag(s)

[Stefan Richter]

Artem S. Tashkinov wrote:
> I quite agree with you that the description is already there, but such 
> flags could help easily review or grep commits in order to identify your 
> areas of interest.
> 
> Even your example has ambiguity: "Wire up new timerfd syscalls" - It's 
> not easy to understand whether this particular commit is a bugfix, or it 
> speeds up things, or the old code which has been cleaned up, etc.

The fundamental problems
  - people sometimes chose bad summaries,
  - we can't always predict the full impact of the patch,
  - what's important for me isn't for you
cannot be solved by your proposed flags.

They can only be solved by
  - reviewing patches WRT good changelogs,
  - writing up extra summary release notes for areas of interest
    after the fact.

>>> It would be nice if [kernel] git commits had a flag [a char] (or a
>>> combination of) describing their main purpose which could be the
>>> following:
>>>
>>> bug Fix [F]
>>> Speed up/Performance [S]
>>> Revert [R]
>>> New functionality [N]

New bug [B]
Attempted bug fix which doesn't really work, a.k.a. nice Try [T]
Performance regression, a.k.a Downgrade [D]
-- 
Stefan Richter
-=====-==--- --== =-=--
http://arcgraph.de/sr/