Re: Resume from swsusp stopped working with 2.6.14 and 2.6.15-rc1

Pavel Machek
2005-11-20T21:22:47Z

Hi!

> > > >> Bjorn, does it help if you change TIMEOUT in kernel/power/process.c to 30 * HZ?
> > > >
> > > > Funny, I thought that 6 seconds is way too much. Bjorn, please let us
> > > > know if 30 seconds timeout helps.
> > >
> > > It does.
> >
> > Ouch, yes, that's clear. It is stopping tasks during *resume*... So I
> > guess it gets wrong timing by design. Question is what to do with
> > that. Could we make keyboard driver pause the boot until it is done
> > resetting hardware? Or we can increase the timeout... would 10 seconds
> > be enough?
>
> Well, I think 10 seconds when suspending is a nice and resonable
> number. For resume though I think we should wait much longer, maybe
> even indefinitely - the only thing that timeout achieves is makes
> people fsck because the system can't recover from that state.

I see your point, but it does not seem we need that changes this far. Your
patch is better, because we *could* hit that during suspend, just after
keyboard hotplug... right? And it will make resume faster for affected people.

--
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms