Re: Resume from swsusp stopped working with 2.6.14 and 2.6.15-rc1

Pavel Machek
2005-11-22T19:01:21Z

Hi!

> > > If a clueless users voice counts for anything: I couldn't agree more.
> > >
> > > A failed resume is a near catastrophy if you use and trust swsusp. And
> > > how could it ever be useful if you don't?
> >
> > Failed resume is only as bad as powerfail.
>
> So? I don't like powerfails either. Could you please answer this
> question - what pros of having resume process time out do you
> envision? What problems does it help to solve?

No advantages, really.. except that it keeps suspend and resume paths
similar, and keeps the code simple. I'll want to call this from
userland and I'd hate to have two different calls or call with
parameter.

> > > Maybe that even would give me a chance to fix some hardware problem
> > > causing the timeout, and then retry the resume.
> >
> > ..while doing resume few times, trying to change hw config to make it
> > resume is _way_ more dangerous.
>
> And still we have to do our best to support it. There is USB,
> Firewire, Docking station that may appear/disappear while box is
> suspended and we absolutely need to support this. Requiring that
> hardware configuration has to be frozen between suspend/resume cycles
> will not get us far.

You may plug/unplug things that are hot-pluggable. If you do something
else (imagine adding or worse removing ram from the system), or do
something "interesting" (boot freebsd, mount ext3 partition,
...)... you loose your data.
Pavel
--
Thanks, Sharp!