From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Ben Dooks <ben-linux@fluff.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: fs/fat - fix sparse warning
Date: Mon, 31 Oct 2005 23:15:34 +0900 [thread overview]
Message-ID: <87zmophiwp.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <20051031113639.GA30667@home.fluff.org> (Ben Dooks's message of "Mon, 31 Oct 2005 11:36:39 +0000")
Ben Dooks <ben-linux@fluff.org> writes:
> move fat_cache_init/fat_cache_destroy to a common
> header file in fs/fat so that inode.c and cache.c
> see the same definition, and to stop warnings
> from sparse about undeclared functions
The fs/fat/* has many internal functions, it is in
include/linux/msdos_fs.h. Please move those internal functions to one
internal header (probably fs/fat/fat.h?).
This seems be just for sparse, please do real cleanup instead.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2005-10-31 14:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-31 11:36 fs/fat - fix sparse warning Ben Dooks
2005-10-31 13:27 ` Alexey Dobriyan
2005-10-31 14:15 ` OGAWA Hirofumi [this message]
2005-11-02 18:04 ` Adrian Bunk
2005-11-02 18:39 ` OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zmophiwp.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=ben-linux@fluff.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox