Re: [PATCH 1/2] Add C99-style constructor macros for specific-sized integers

H. Peter Anvin
2008-03-03T04:53:31Z

David Brownell wrote:
> On Sunday 02 March 2008, Segher Boessenkool wrote:
>
>> Do these new macros really buy anything over just writing LL in the
>> few places that 64-bit constants are used?
>
> The original workaround was to make the offending *SEC_TO_HZ_ADJ32
> constants use "ULL" suffixes. Certainly making the Perl script emit
> those would be less intrusive.
>

"Less intrusive" in the sense of smaller line count for this particular
patch, perhaps, but it makes it less obvious when reading the code
what's going on (a size override in an entirely different file).
Additionally, I'm hoping these kind of things can be used elsewhere; the
C99 <inttypes.h> facilities are really quite nice once you get over the
rather ugly look of them, and I for one definitely miss having access to
the in the kernel.

-hpa