From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2916C00528 for ; Mon, 7 Aug 2023 14:56:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229947AbjHGO4z (ORCPT ); Mon, 7 Aug 2023 10:56:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229849AbjHGO4n (ORCPT ); Mon, 7 Aug 2023 10:56:43 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7238F10F8 for ; Mon, 7 Aug 2023 07:56:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691420202; x=1722956202; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=lK5NaO7oefA5g11ZXsxw+6NSKHBHesJlzzBUmcoECcY=; b=CBH3khPlqrdgg95ueSJDTVjbmO052vV+1Y2XaS6OMoyxglgn0u1BSV12 U85Yu6i86ke6e9oyKWWKE7w4fKgwM+22F+CQaxRRIrPHZHAN3JnGu0R07 HP5oTGwfBCy9n38iyqms/VTTdP7nZ2CpehfHxY1eB9ZcjXQUsY13BiuAG cx+f4+3LfuomYUKXoz8VJ+FnegytTGD1qp+vdE8j3Z5/qGK4Y9Emp5Uqs oVH2R0jgfAXgY9fWSmrWPUu6JVssWqTt2PsSg0ve+kdDYO8gjouNqkV27 uooXfY3A8k7O4lbZYajhpiVzgQfx6V74HdbQDDospWGWzS9PsaUfDdR/f Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="434410620" X-IronPort-AV: E=Sophos;i="6.01,262,1684825200"; d="scan'208";a="434410620" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Aug 2023 07:56:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="1061623884" X-IronPort-AV: E=Sophos;i="6.01,262,1684825200"; d="scan'208";a="1061623884" Received: from hweelee-mobl.amr.corp.intel.com (HELO [10.209.181.215]) ([10.209.181.215]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Aug 2023 07:56:41 -0700 Message-ID: <880a953d-bc81-5f00-7ad6-bbcf6eaac856@linux.intel.com> Date: Mon, 7 Aug 2023 09:17:43 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.13.0 Subject: Re: [PATCH v3 7/9] ALSA: hda/intel: Move snd_hdac_i915_init to before probe_work. Content-Language: en-US To: Maarten Lankhorst , alsa-devel@alsa-project.org Cc: Maarten Lankhorst , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Kai Vehmanen , Mark Brown , Daniel Baluta , linux-kernel@vger.kernel.org, sound-open-firmware@alsa-project.org References: <20230807090045.198993-1-maarten.lankhorst@linux.intel.com> <20230807090045.198993-8-maarten.lankhorst@linux.intel.com> From: Pierre-Louis Bossart In-Reply-To: <20230807090045.198993-8-maarten.lankhorst@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/7/23 04:00, Maarten Lankhorst wrote: > Now that we can use -EPROBE_DEFER, it's no longer required to spin off > the snd_hdac_i915_init into a workqueue. > > Use the -EPROBE_DEFER mechanism instead, which must be returned in the > probe function. > > Changes since v1: > - Use dev_err_probe() > - Don't move probed_devs bitmap unnecessarily. (tiwai) > - Move snd_hdac_i915_init slightly upward, to ensure > it's always initialised before vga-switcheroo is called. same issue with changes. > > Signed-off-by: Maarten Lankhorst > Reviewed-by: Kai Vehmanen Reviewed-by: Pierre-Louis Bossart