From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8ADF1E834E for ; Sat, 14 Feb 2026 16:44:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771087467; cv=none; b=rQTyJFEKluGB9awHSXVFtY45gIPeMybOXOAlvQ3ClFSnIkiCoT/uYLmM0YlMnijg6cYPIeSclXYvL7RzThqPTHkfb2ijDE8m1UAaqJXf833ONt5lxAfqtPvk92KsGRQadX0vlLFaqCJgScpkvaw+k7uHDhSCvtUw+CNCUoeU0Cw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771087467; c=relaxed/simple; bh=5M74aqtSckhkCFRe9Mo0Ybki6y+La8FS64rrC4ZViZA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iQah6IcsekHgTfAiOcsQ1VsmGEyABUlMV/ELep1CUkPAKmcK+ckqHv5/ad1f/ld4YWnvC2geWbhwImcM2NRKp6hDmfBftKT6P4QrwhOjyy1DxLOQtediGke3ZCs3tiLrpl7zyXtvBZm9Ta8JwqKfUCSA+1prvuC0HnN/tZDsWVM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=cD+VED4p; arc=none smtp.client-ip=209.85.210.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="cD+VED4p" Received: by mail-ot1-f45.google.com with SMTP id 46e09a7af769-7d4c383f2fcso1208313a34.0 for ; Sat, 14 Feb 2026 08:44:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1771087465; x=1771692265; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1f3FaAfJ8qGEhkE04fqgomCWXCa7hwpoZ04n55k5H08=; b=cD+VED4p1ADwFS8CCrEPkxelQtcgzzhxX4PQdh9iGp2MtE2TNrl8m++Qp7VPjzha18 0kUpoHj2G48U7JmUGfGlDcztDmfm3S4nJBnAQl2dxqhI/jMjuUk6aY0VJpYnMsTjrSAX fZmQICX/572P8q8xP2BXloOasMscfHNgGKtdiZnJfoqDqBME4ps6T+K2VgO/kz62maKS QwI1lb5A/HGNps3KTTJzX6PbqAGDAMUha1mjoIWjbmUxFy+URY9fGg8LVea1e8q/PJAP yu2km6QKfhWXJL+EIRlGN1C3Z6KW+z13xPDFfmlL7znozugc4k19GtQrmUtONZpOmIKx 9sdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771087465; x=1771692265; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1f3FaAfJ8qGEhkE04fqgomCWXCa7hwpoZ04n55k5H08=; b=rzshZ/H6QdqUpGPEq7/VFXTq+hsllniJ/evYYLmkILcOIH72SRziAkS3LvFZN0jTgE kHq+z9Seuz2Apw96r/3X/lnR7/VUTkeMQ4Ttr5Us+R9IiZqfBRxGURhRFz/QHlNKSS11 bhokLDj9ecJ+UntVb4IHzEMCmITB+7cfbgW7TBcB1314mIh8P5iAvhD2lOUvvgR6PZnj 30I35SYSrir7ZKBITJvkYGeJob5z97ptboxeVHRZ1cm+Mq/EkKb980uP8Mq7RwMhIzhf EyBwoh9gAC3XFOI00a/8/jp+UHDHpz2qnPZjF8HAkIbVZ/mdYfirWdAd0jbhziPINkWb 0GAg== X-Forwarded-Encrypted: i=1; AJvYcCUZ8fsJkhjvc03+kIfUlA97J7iAtStURsq9iiMnWBuoUVcMnaGIFxOvjgZQZgaH4JxaSl0JvUY7A0XM5pQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxXaFWJiTi2SpKqGMY3rGreNXvoU5ddCGE74Be7hGfmygkqC8iU CtYOQk1yA7WaEPP7khkk+BIYa2FgHNy3tOaQOSz5wV41ts7ZaZV5idVV78xeSMI+ugA= X-Gm-Gg: AZuq6aIWIaOrXqMQicEwWBYu93uBM8h95mDvnQs80sx7s+yo8w+yLa/gnJd3I67ur7I 4vVd/CDs9ylHkl2GsMvm0WqMaRuNpgm5QsToGjZ6UZm5nt99h2cP0wCMYPcZzJmXSj3YW3UguoZ uTnhHfsB+zjv/Gy/yDX/hwB7pKD8mrSAezMHwq8kKeR7xh4oVWHjS+RBzlKuxPV/oGjtHY3m18T gbEzKKahE2bH3+R3k1r5FhLZIz2zFN6geExjqVAc6BAEf2F0iirmthmnxw15aYQ/L0fvrlf88aX QdMXEeJfdjyeiyii6Wf0jIgdVRhPFxGae0Cm+Wp7z2h1kIfMEqADwW7qKdBSwjosd8yLAVfNTlK an3eXTck0j/I5miP8jqphRl0ju2Y2zyPW+JBxgJlu00uedQmTnwy7DhyyYaCeZHq/B2kgNK2zsI VM8VcYq/tligaTkF+mmb/W+336V/ncqJ2AJb9SLQ089KxjzgZ8TJw+PhABryw0Hg0bRzS1D2cuH wWWY7t8 X-Received: by 2002:a05:6830:2682:b0:7d1:95c7:f4cf with SMTP id 46e09a7af769-7d4c4a3becbmr3507186a34.14.1771087464786; Sat, 14 Feb 2026 08:44:24 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:109:393c:254e:962e? ([2600:8803:e7e4:500:109:393c:254e:962e]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d4a75309bcsm8641964a34.1.2026.02.14.08.44.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 14 Feb 2026 08:44:24 -0800 (PST) Message-ID: <880ddcad-a92e-43bb-ad5c-d6f2f353d182@baylibre.com> Date: Sat, 14 Feb 2026 10:44:23 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/2] dt-bindings: iio: light: vcnl4000: add Capella CM36686 and CM36672P To: Erikas Bitovtas , Krzysztof Kozlowski Cc: Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org References: <20260212-cm36686-v4-0-8f587d4a72bf@gmail.com> <20260212-cm36686-v4-1-8f587d4a72bf@gmail.com> <20260213-unyielding-pistachio-ape-deda74@quoll> <3a20c906-647c-458f-a118-c7927495e7ef@gmail.com> <8fb27a7a-82dc-443b-bcc4-21007783fc54@kernel.org> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/13/26 2:56 AM, Erikas Bitovtas wrote: > > > On 2/13/26 10:51 AM, Krzysztof Kozlowski wrote: >> On 13/02/2026 09:29, Erikas Bitovtas wrote: >>>>> Signed-off-by: Erikas Bitovtas >>>>> --- >>>>> .../devicetree/bindings/iio/light/vishay,vcnl4000.yaml | 17 +++++++++++------ >>>>> 1 file changed, 11 insertions(+), 6 deletions(-) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml >>>>> index 4d1a225e8868..2ba4d5de4ec4 100644 >>>>> --- a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml >>>>> +++ b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml >>>>> @@ -18,12 +18,17 @@ allOf: >>>>> >>>>> properties: >>>>> compatible: >>>>> - enum: >>>>> - - vishay,vcnl4000 >>>>> - - vishay,vcnl4010 >>>>> - - vishay,vcnl4020 >>>>> - - vishay,vcnl4040 >>>>> - - vishay,vcnl4200 >>>>> + oneOf: >>>>> + - enum: >>>>> + - capella,cm36672p >>>> >>>> CM36672P is compatible with CM36686, but this is not expressed. >>>> Confusing commit msg and code. >>> >>> For CM36672P we create a dedicated compatible because it is a >>> proximity-only sensor which has the same proximity sensor configuration, >>> but ambient light sensor registers are missing (reserved). >> >> I don't understand this. You just wrote "fully compatible with CM36686" >> and now you imply that not. >> >> Decide. >> > It is not. CM36672P supports only a subset of CM36686 features, in > particular the proximity sensor. That is what I meant initially. > I am sorry if the previous phrasing caused any confusion. But CM36686 is fully compatible with CM36672P, right? So this would make sense? - items: - const: capella,cm36686 - const: vishay,vcnl4040 - const: capella,cm36686p