* [PATCH] ALSA: hda/cs35l56: select FW_CS_DSP
@ 2025-05-20 15:26 Arnd Bergmann
2025-05-20 15:55 ` Richard Fitzgerald
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2025-05-20 15:26 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai, Richard Fitzgerald
Cc: Arnd Bergmann, linux-sound, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
When compile-testing this driver, the missing FW_CS_DSP module
causes a link failure:
aarch64-linux-ld: sound/pci/hda/cs35l41_hda.o: in function `cs35l41_shutdown_dsp':
cs35l41_hda.c:(.text+0x7e4): undefined reference to `cs_dsp_stop'
aarch64-linux-ld: cs35l41_hda.c:(.text+0x7ec): undefined reference to `cs_dsp_power_down'
aarch64-linux-ld: sound/pci/hda/cs35l41_hda.o: in function `cs35l41_hda_remove':
cs35l41_hda.c:(.text+0x14b4): undefined reference to `cs_dsp_remove'
aarch64-linux-ld: sound/pci/hda/cs35l41_hda.o: in function `cs35l41_smart_amp.isra.0':
cs35l41_hda.c:(.text+0x189c): undefined reference to `cs_dsp_halo_init'
aarch64-linux-ld: cs35l41_hda.c:(.text+0x1bd4): undefined reference to `cs_dsp_power_up'
aarch64-linux-ld: cs35l41_hda.c:(.text+0x1c38): undefined reference to `cs_dsp_run'
aarch64-linux-ld: cs35l41_hda.c:(.text+0x1c80): undefined reference to `cs_dsp_get_ctl'
aarch64-linux-ld: cs35l41_hda.c:(.text+0x1c90): undefined reference to `cs_dsp_coeff_read_ctrl'
aarch64-linux-ld: cs35l41_hda.c:(.text+0x1cd4): undefined reference to `cs_dsp_get_ctl'
aarch64-linux-ld: cs35l41_hda.c:(.text+0x1ce4): undefined reference to `cs_dsp_coeff_read_ctrl'
Fixes: 849c83fe4991 ("ALSA: hda/cs35l56: Remove dependency on COMPILE_TEST")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
sound/pci/hda/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/Kconfig b/sound/pci/hda/Kconfig
index 339c80d2cce5..3d4badc3f0e0 100644
--- a/sound/pci/hda/Kconfig
+++ b/sound/pci/hda/Kconfig
@@ -109,6 +109,7 @@ config SND_HDA_SCODEC_CS35L41
tristate
select SND_HDA_GENERIC
select REGMAP_IRQ
+ select FW_CS_DSP
config SND_HDA_SCODEC_COMPONENT
tristate
--
2.39.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ALSA: hda/cs35l56: select FW_CS_DSP
2025-05-20 15:26 [PATCH] ALSA: hda/cs35l56: select FW_CS_DSP Arnd Bergmann
@ 2025-05-20 15:55 ` Richard Fitzgerald
2025-05-20 16:22 ` Arnd Bergmann
0 siblings, 1 reply; 3+ messages in thread
From: Richard Fitzgerald @ 2025-05-20 15:55 UTC (permalink / raw)
To: Arnd Bergmann, Jaroslav Kysela, Takashi Iwai
Cc: Arnd Bergmann, linux-sound, linux-kernel
On 20/05/2025 4:26 pm, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When compile-testing this driver, the missing FW_CS_DSP module
> causes a link failure:
>
> aarch64-linux-ld: sound/pci/hda/cs35l41_hda.o: in function `cs35l41_shutdown_dsp':
> cs35l41_hda.c:(.text+0x7e4): undefined reference to `cs_dsp_stop'
> aarch64-linux-ld: cs35l41_hda.c:(.text+0x7ec): undefined reference to `cs_dsp_power_down'
> aarch64-linux-ld: sound/pci/hda/cs35l41_hda.o: in function `cs35l41_hda_remove':
> cs35l41_hda.c:(.text+0x14b4): undefined reference to `cs_dsp_remove'
> aarch64-linux-ld: sound/pci/hda/cs35l41_hda.o: in function `cs35l41_smart_amp.isra.0':
> cs35l41_hda.c:(.text+0x189c): undefined reference to `cs_dsp_halo_init'
> aarch64-linux-ld: cs35l41_hda.c:(.text+0x1bd4): undefined reference to `cs_dsp_power_up'
> aarch64-linux-ld: cs35l41_hda.c:(.text+0x1c38): undefined reference to `cs_dsp_run'
> aarch64-linux-ld: cs35l41_hda.c:(.text+0x1c80): undefined reference to `cs_dsp_get_ctl'
> aarch64-linux-ld: cs35l41_hda.c:(.text+0x1c90): undefined reference to `cs_dsp_coeff_read_ctrl'
> aarch64-linux-ld: cs35l41_hda.c:(.text+0x1cd4): undefined reference to `cs_dsp_get_ctl'
> aarch64-linux-ld: cs35l41_hda.c:(.text+0x1ce4): undefined reference to `cs_dsp_coeff_read_ctrl'
>
> Fixes: 849c83fe4991 ("ALSA: hda/cs35l56: Remove dependency on COMPILE_TEST")
But the error messages above and the change below are for CS35L41
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> sound/pci/hda/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/pci/hda/Kconfig b/sound/pci/hda/Kconfig
> index 339c80d2cce5..3d4badc3f0e0 100644
> --- a/sound/pci/hda/Kconfig
> +++ b/sound/pci/hda/Kconfig
> @@ -109,6 +109,7 @@ config SND_HDA_SCODEC_CS35L41
> tristate
> select SND_HDA_GENERIC
> select REGMAP_IRQ
> + select FW_CS_DSP
>
> config SND_HDA_SCODEC_COMPONENT
> tristate
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ALSA: hda/cs35l56: select FW_CS_DSP
2025-05-20 15:55 ` Richard Fitzgerald
@ 2025-05-20 16:22 ` Arnd Bergmann
0 siblings, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2025-05-20 16:22 UTC (permalink / raw)
To: Richard Fitzgerald, Arnd Bergmann, Jaroslav Kysela, Takashi Iwai
Cc: linux-sound, linux-kernel
On Tue, May 20, 2025, at 17:55, Richard Fitzgerald wrote:
> On 20/05/2025 4:26 pm, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> Fixes: 849c83fe4991 ("ALSA: hda/cs35l56: Remove dependency on COMPILE_TEST")
>
> But the error messages above and the change below are for CS35L41
Sorry about that, I think I found the correct cause now and sent a v2.
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-05-20 16:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-20 15:26 [PATCH] ALSA: hda/cs35l56: select FW_CS_DSP Arnd Bergmann
2025-05-20 15:55 ` Richard Fitzgerald
2025-05-20 16:22 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).