From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97A78346E7A for ; Thu, 7 May 2026 16:55:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778172959; cv=none; b=m2Ijkj8YA+yBufrWHC/DQJEqRuwv6CVFiGyeWVEZMJ6Mncvg9HRLhVpN/1up+aqRctXxr9fnyroksqgbZnyep/38g1cSEyhDxm+0w3Kz7LWv8vGnpt8OgiRG9rTry/jXQenbtf/dabMQN/iBrKjPxpQJHV84wjQTOZyZjg264Y4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778172959; c=relaxed/simple; bh=LHW4P3S1PHptuizxldqf/3Vcv1k1Ssfaue4jpA+d/lY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=u0K/9yDgfhY6ODHuVsJT3V3/HEUX7T1jhg5EeiZLUqbyAQT9RgwIQIt6I0tAG3v0hUpgLgQzjq7euOaeZFhSCVyxBvffVcw6Km3IlDssUSBP9KjPKp9M3Rnf/eYduOm3iK1LkLIvFPCBYhlnGsE1oJhjH4ALgNI96IbVjU+bB0A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=d1XwQngh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="d1XwQngh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9123EC2BCB2; Thu, 7 May 2026 16:55:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778172959; bh=LHW4P3S1PHptuizxldqf/3Vcv1k1Ssfaue4jpA+d/lY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=d1XwQngh1zmlvMCgQEMytEecBAjTWlSZg972op07cRwrQkUvku8qPTDc0X4qLBSZD HY1ThCLYm8MvZFTPYU/mKyjuXjD6PHsmN414hxdeXES+SUwmHIMIXf36MXQCMSOLIN TRktrQwKHD6ijvgV+fwqyuhk1glVG7l9/FIi10+Q1q7o8K4HwNl7SapvLjYU7fQUa1 iQW3Pl8Id0T9UBE5DtYfHfkdoFmgtm64or+h1Qz7YwYwM1ysgLy03mdIlEhg4kDVMc 9MkEFwmaBhFCWvoyLWQUj3D687hkTkG0+26y7LMol+J2cqOLk6Y8Cnlsdk0Q24xdwk AFEtsZIdPZL8Q== Message-ID: <88330822-679b-497a-a2a1-93e0176cf022@kernel.org> Date: Thu, 7 May 2026 11:55:57 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V1] accel/amdxdna: Fix clflush buffer size Content-Language: en-US To: Lizhi Hou , ogabbay@kernel.org, quic_jhugo@quicinc.com, dri-devel@lists.freedesktop.org, karol.wachowski@linux.intel.com Cc: linux-kernel@vger.kernel.org, max.zhen@amd.com, sonal.santan@amd.com References: <20260507040207.178111-1-lizhi.hou@amd.com> From: Mario Limonciello In-Reply-To: <20260507040207.178111-1-lizhi.hou@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/6/26 23:02, Lizhi Hou wrote: > The firmware is told the buffer is req.buf_size bytes. It may read/write > the entire region. If the CPU only flushes a subset, the remaining cache > lines could contain stale data, causing the device to see garbage. > > Fixes: 6e87001fe19f ("accel/amdxdna: Adjust size for copy_to_user()") > Signed-off-by: Lizhi Hou Reviewed-by: Mario Limonciello (AMD) > --- > drivers/accel/amdxdna/aie2_message.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/accel/amdxdna/aie2_message.c b/drivers/accel/amdxdna/aie2_message.c > index 6e98af7b74db..a012e7e935ad 100644 > --- a/drivers/accel/amdxdna/aie2_message.c > +++ b/drivers/accel/amdxdna/aie2_message.c > @@ -390,7 +390,7 @@ int aie2_query_status(struct amdxdna_dev_hdl *ndev, char __user *buf, > req.num_cols = hweight32(aie_bitmap); > req.aie_bitmap = aie_bitmap; > > - drm_clflush_virt_range(buff_addr, size); /* device can access */ > + drm_clflush_virt_range(buff_addr, req.dump_buff_size); /* device can access */ > ret = aie_send_mgmt_msg_wait(&ndev->aie, &msg); > if (ret) { > XDNA_ERR(xdna, "Error during NPU query, status %d", ret); > @@ -442,7 +442,7 @@ int aie2_query_telemetry(struct amdxdna_dev_hdl *ndev, > req.buf_size = buf_sz; > req.type = header->type; > > - drm_clflush_virt_range(addr, size); /* device can access */ > + drm_clflush_virt_range(addr, req.buf_size); /* device can access */ > ret = aie_send_mgmt_msg_wait(&ndev->aie, &msg); > if (ret) { > XDNA_ERR(xdna, "Query telemetry failed, status %d", ret); > @@ -1186,7 +1186,7 @@ int aie2_query_app_health(struct amdxdna_dev_hdl *ndev, u32 context_id, > req.context_id = context_id; > req.buf_size = buf_size; > > - drm_clflush_virt_range(buf, sizeof(*report)); > + drm_clflush_virt_range(buf, req.buf_size); > ret = aie_send_mgmt_msg_wait(&ndev->aie, &msg); > if (ret) { > XDNA_ERR(xdna, "Get app health failed, ret %d status 0x%x", ret, resp.status);