Re: [PATCH v2] {tty: serial, nand: onenand}: samsung: rename to fix build warning

Greg Kroah-Hartman
2019-11-18T11:47:03Z

On Sun, Nov 17, 2019 at 08:24:35PM +0000, Sudip Mukherjee wrote:
> Any arm config which has 'CONFIG_MTD_ONENAND_SAMSUNG=m' and
> 'CONFIG_SERIAL_SAMSUNG=m' gives a build warning:
>
> warning: same module names found:
> drivers/tty/serial/samsung.ko
> drivers/mtd/nand/onenand/samsung.ko
>
> Rename both drivers/tty/serial/samsung.c to
> drivers/tty/serial/samsung_tty.c and drivers/mtd/nand/onenand/samsung.c
> drivers/mtd/nand/onenand/samsung_mtd.c to fix the warning.
>
> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> ---
>
> v1: only renamed drivers/tty/serial/samsung.c
> link: https://lore.kernel.org/lkml/20191018194707.27188-1-sudipm.mukherjee@gmail.com
>
> v2: rename both files.
>
> I was not sure if this should have been two different patch, but since
> this will be fixing the same problem so it seems its better to have them
> in a single patch.
>
> drivers/mtd/nand/onenand/Makefile | 2 +-
> drivers/mtd/nand/onenand/{samsung.c => samsung_mtd.c} | 0
> drivers/tty/serial/Makefile | 2 +-
> drivers/tty/serial/{samsung.c => samsung_tty.c} | 0
> 4 files changed, 2 insertions(+), 2 deletions(-)
> rename drivers/mtd/nand/onenand/{samsung.c => samsung_mtd.c} (100%)
> rename drivers/tty/serial/{samsung.c => samsung_tty.c} (100%)

I can take this in the tty tree if the mtd maintainer gives an ack for
it...