From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B49D79CD for ; Wed, 21 Aug 2024 06:30:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724221860; cv=none; b=ryEx5rLseVEKi5ANyirgOuLEZSv3DkGMCYpTIvHu/u1gqWlA7TrkyfLUs2M6Zwz5I2J3GurFOOuQTd7jMKa8vnf9AsGF908jcfkA8b1aZlJQg3Xrvv1+hs3Cll/IUOd/hD86b1c1PwdJlD/aSZOv5mKEsZBStWUl8/XL8v0VMBk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724221860; c=relaxed/simple; bh=mZ7cSxfoQmQCj3saPrfeUJA2a4NYfq6piA/iUeVZ7WU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iJ3njGKHao/pcqg0Y/3W6jEARtJpJgS38yjBnmU0vfVGHVQjo76JLECY2x2UCOENYB256ecXhSW4Szx2FiBINLdisNvJzoyAwon/tzAzrccYbZd/DE2XqXGny9WlKKmo5LR7Dcrqttyx2EV+8JZJoSYaFXN2aEsufXDaKjEv1NI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=aml5LfgC; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="aml5LfgC" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-201ed196debso52518665ad.1 for ; Tue, 20 Aug 2024 23:30:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1724221857; x=1724826657; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YzcqzHSqNE9yip5ED7tWvIVzWmQ91EinUBi740+qVHE=; b=aml5LfgCRrzx7LuSFL/wQgM/293b8BAadEgDoHrhj4siR8FAurdqZe8GZabFiRdTKg dn6aZZz2tTJxuxD87lbXheGVLBSTwUxI2EuuYZZyOBFk5t9aAQmR1kh7tRzQd9fdKp7A 3BnNeuTG4zBehbeiyb3BxUCfflV117eoExDdg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724221857; x=1724826657; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YzcqzHSqNE9yip5ED7tWvIVzWmQ91EinUBi740+qVHE=; b=tP2pmU/7DSUhs3nvgpFbKz0wRYFoSOfang/ux7dZ3hO0SKHx7S842Yh77chdxSg7Z/ zxE2yo1/Mw4pqLjnNu8Iuk/qc+/vkqpxL+gfFIAyaOSrVNjkPIW6aG/EmCEJJRoT3nJF LiYUERySm6HGZ80oZ0asnJoGP6qtMQAzWpMna/yaIURTfWJWvVTO6U14fUgu+edDCwY/ E5J8XgGTWr7TEAJa8AiOCXwte5dL8GNaOgwuK/Y9yetcEYe/phX/Nnpe6Yvdvd/ADmva Biyq5euaKFnmMQpVIg9O0kvZJxSeGIGLT1hPk3Pkn6j70lVdnNLvAbfiJEwT7uiae+78 gPPw== X-Gm-Message-State: AOJu0Yxx0mjWcGpCnDAxczsUovmrmJuSxl4Hr3EgUIGHz5Sd48Q8ccur FxZCScp7cUvoQCZlVCSwT28J9I/5uZGWrsxZowOgFgAQJ5/QculSx7jHDurDDlI= X-Google-Smtp-Source: AGHT+IEnOoIZoPGx6TQyxJmMjyll5R6KO1MT+r2PvrLNAVJhrjTw3Spm91pOn5tWFC5QIEziQ7p6wA== X-Received: by 2002:a17:902:c40b:b0:201:db9f:cdde with SMTP id d9443c01a7336-20367d56b58mr15815015ad.34.1724221856606; Tue, 20 Aug 2024 23:30:56 -0700 (PDT) Received: from [172.20.0.208] ([218.188.70.188]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-201f0300522sm87065175ad.6.2024.08.20.23.30.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Aug 2024 23:30:56 -0700 (PDT) Message-ID: <88575c79-b6be-42d2-b863-d57f83f8c99c@linuxfoundation.org> Date: Wed, 21 Aug 2024 00:30:53 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] selftests: Fix cpuid / vendor checking build issues To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Muhammad Usama Anjum , Shuah Khan , Reinette Chatre , linux-kselftest@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Shaopeng Tan , Fenghua Yu , Shuah Khan References: <20240813104515.19152-1-ilpo.jarvinen@linux.intel.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20240813104515.19152-1-ilpo.jarvinen@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 8/13/24 04:45, Ilpo Järvinen wrote: > First, generalize resctrl selftest non-contiguous CAT check to not > assume non-AMD vendor implies Intel. Second, improve kselftest common > parts and resctrl selftest such that the use of __cpuid_count() does > not lead into a build failure (happens at least on ARM). > > The last patch might still require some work on which symbol the > conditional in kselftest.h is implemented. I could not find any > pre-existing one that could be used. Perhaps somebody who's more > familiar with the kselftest build system has a better suggestion on > which symbol the logic should be based at? > > Ilpo Järvinen (3): > selftests/resctrl: Generalize non-contiguous CAT check > selftests/resctrl: Always initialize ecx to avoid build warnings > [RFC] kselftest: Provide __cpuid_count() stub on non-x86 archs > > tools/testing/selftests/kselftest.h | 6 +++++ > tools/testing/selftests/lib.mk | 4 ++++ > tools/testing/selftests/resctrl/cat_test.c | 28 +++++++++++++--------- > 3 files changed, 27 insertions(+), 11 deletions(-) > These changes look good to me. Can you send the RFC patch without the RFC tag for me to pull in? I don't apply RFC patches. Usama, does this fix the problem you are seeing? Hi Reinette - do these look okay to you? Can you give me an ack if they do? thanks, -- Shuah