From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9435646BF for ; Tue, 17 Feb 2026 08:41:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771317703; cv=none; b=F4mYAsH3Dat05Wrs+GIrHjCRMC2NKClJhep5qFHrUh7/MiU5wtv+OGVa7JdynMPjziJO9FAMsUSgmOJrh73q033FJ7/C5UrqTezB8CEnURMWe1TwsG09YKG90zjeNJJgB//oAyzrxJPwzJyjV97KEivhpsnTifttpesCwHEkVEI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771317703; c=relaxed/simple; bh=nLSEueKo1tSZ5piHVrWabWUZj767BmLajsz6Qnb+DpQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WrjnUJ68021ucLhC1nP1CUKcvtG8Cn0aMnIlNxnXPYkKbOh5ciep4v5gBwkIVXwlu0cZ/6CCE2qVHrx4g0JWlO9izbXegBxmSBSSTKMOUA4Z4SdO5S2A/KPB6i6ysc7ng0XzRKxqEkkyoL9CdSlriD6L1WPmyD5FzxEFBabO5rE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=mDqFuz9X; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=s3YUIuKE; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=mDqFuz9X; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=s3YUIuKE; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="mDqFuz9X"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="s3YUIuKE"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="mDqFuz9X"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="s3YUIuKE" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CB6565BD31; Tue, 17 Feb 2026 08:41:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1771317700; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EH9/rerst7oe8WU1AFu95buok2Cxi654hXfQWqS/pE8=; b=mDqFuz9XKg6kYExQNpVq/TjH8BD6zyEu8ftgmKzHuVS2flVUjO8xTEnPSSJALysWLzkFuu bFDfP+s+DArOR7xenMM0sQaCsZwa9lEe2kAs8oupKVYx7tMy2wDOEMrBkkkvG8BpFHYZgF m8IGo6u+LzchuHtKaPBQx+aEMtrGYT0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1771317700; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EH9/rerst7oe8WU1AFu95buok2Cxi654hXfQWqS/pE8=; b=s3YUIuKEt7yxc34B/Wrz8FdRq8F6JTbi4Hy9iTlOWAz1IIRRCjedvsLC+HR7wlGAVsJq9+ lfDrUPMfRur22kAA== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1771317700; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EH9/rerst7oe8WU1AFu95buok2Cxi654hXfQWqS/pE8=; b=mDqFuz9XKg6kYExQNpVq/TjH8BD6zyEu8ftgmKzHuVS2flVUjO8xTEnPSSJALysWLzkFuu bFDfP+s+DArOR7xenMM0sQaCsZwa9lEe2kAs8oupKVYx7tMy2wDOEMrBkkkvG8BpFHYZgF m8IGo6u+LzchuHtKaPBQx+aEMtrGYT0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1771317700; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EH9/rerst7oe8WU1AFu95buok2Cxi654hXfQWqS/pE8=; b=s3YUIuKEt7yxc34B/Wrz8FdRq8F6JTbi4Hy9iTlOWAz1IIRRCjedvsLC+HR7wlGAVsJq9+ lfDrUPMfRur22kAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id AAEF33EA65; Tue, 17 Feb 2026 08:41:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Qea8I8MplGlOaQAAD6G6ig (envelope-from ); Tue, 17 Feb 2026 08:41:39 +0000 Message-ID: <885e4324-ab9b-476a-9c69-afc3d9e894e4@suse.de> Date: Tue, 17 Feb 2026 09:41:36 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/tiny: sharp-memory: fix pointer error dereference To: Ethan Tidmore , lanzano.alex@gmail.com Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org, airlied@gmail.com, simona@ffwll.ch, lumag@kernel.org, mehdi.djait@bootlin.com, u.kleine-koenig@baylibre.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260216040438.43702-1-ethantidmore06@gmail.com> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: <20260216040438.43702-1-ethantidmore06@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -2.80 X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TAGGED_RCPT(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_SEVEN(0.00)[11]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[linux.intel.com,kernel.org,gmail.com,ffwll.ch,bootlin.com,baylibre.com,lists.freedesktop.org,vger.kernel.org]; MID_RHS_MATCH_FROM(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; URIBL_BLOCKED(0.00)[imap1.dmz-prg2.suse.org:helo,suse.com:url,suse.de:mid,suse.de:email]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid,suse.de:email,suse.com:url] X-Spam-Level: X-Spam-Flag: NO Am 16.02.26 um 05:04 schrieb Ethan Tidmore: > The function devm_drm_dev_alloc() returns a pointer error upon failure > not NULL. Change null check to pointer error check. > > Detected by Smatch: > drivers/gpu/drm/tiny/sharp-memory.c:549 sharp_memory_probe() error: > 'smd' dereferencing possible ERR_PTR() > > Fixes: b8f9f21716fec ("drm/tiny: Add driver for Sharp Memory LCD") > Signed-off-by: Ethan Tidmore Reviewed-by: Thomas Zimmermann Thanks for the fix. > --- > drivers/gpu/drm/tiny/sharp-memory.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/tiny/sharp-memory.c b/drivers/gpu/drm/tiny/sharp-memory.c > index 64272cd0f6e2..cbf69460ebf3 100644 > --- a/drivers/gpu/drm/tiny/sharp-memory.c > +++ b/drivers/gpu/drm/tiny/sharp-memory.c > @@ -541,8 +541,8 @@ static int sharp_memory_probe(struct spi_device *spi) > > smd = devm_drm_dev_alloc(dev, &sharp_memory_drm_driver, > struct sharp_memory_device, drm); > - if (!smd) > - return -ENOMEM; > + if (IS_ERR(smd)) > + return PTR_ERR(smd); > > spi_set_drvdata(spi, smd); > -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)