From: Walker Chen <walker.chen@starfivetech.com>
To: Changhuang Liang <changhuang.liang@starfivetech.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Conor Dooley <conor@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>
Cc: Hal Feng <hal.feng@starfivetech.com>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-riscv@lists.infradead.org>
Subject: Re: [PATCH v3 3/5] soc: starfive: Extract JH7110 pmu private operations
Date: Wed, 10 May 2023 14:51:40 +0800 [thread overview]
Message-ID: <88660bc1-035c-fa7b-d541-d29bc142e043@starfivetech.com> (raw)
In-Reply-To: <20230510015311.27505-4-changhuang.liang@starfivetech.com>
On 2023/5/10 9:53, Changhuang Liang wrote:
> Move JH7110 private operation into private data of compatible. Convenient
> to add AON PMU which would not have interrupts property.
>
> Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
Reviewed-by: Walker Chen <walker.chen@starfivetech.com>
Thanks!
> ---
> drivers/soc/starfive/jh71xx_pmu.c | 89 +++++++++++++++++++++----------
> 1 file changed, 62 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/soc/starfive/jh71xx_pmu.c b/drivers/soc/starfive/jh71xx_pmu.c
> index 7d5f50d71c0d..0dbdcc0d2c91 100644
> --- a/drivers/soc/starfive/jh71xx_pmu.c
> +++ b/drivers/soc/starfive/jh71xx_pmu.c
> @@ -51,9 +51,17 @@ struct jh71xx_domain_info {
> u8 bit;
> };
>
> +struct jh71xx_pmu;
> +struct jh71xx_pmu_dev;
> +
> struct jh71xx_pmu_match_data {
> const struct jh71xx_domain_info *domain_info;
> int num_domains;
> + unsigned int pmu_status;
> + int (*pmu_parse_irq)(struct platform_device *pdev,
> + struct jh71xx_pmu *pmu);
> + int (*pmu_set_state)(struct jh71xx_pmu_dev *pmd,
> + u32 mask, bool on);
> };
>
> struct jh71xx_pmu {
> @@ -79,12 +87,12 @@ static int jh71xx_pmu_get_state(struct jh71xx_pmu_dev *pmd, u32 mask, bool *is_o
> if (!mask)
> return -EINVAL;
>
> - *is_on = readl(pmu->base + JH71XX_PMU_CURR_POWER_MODE) & mask;
> + *is_on = readl(pmu->base + pmu->match_data->pmu_status) & mask;
>
> return 0;
> }
>
> -static int jh71xx_pmu_set_state(struct jh71xx_pmu_dev *pmd, u32 mask, bool on)
> +static int jh7110_pmu_set_state(struct jh71xx_pmu_dev *pmd, u32 mask, bool on)
> {
> struct jh71xx_pmu *pmu = pmd->pmu;
> unsigned long flags;
> @@ -92,22 +100,8 @@ static int jh71xx_pmu_set_state(struct jh71xx_pmu_dev *pmd, u32 mask, bool on)
> u32 mode;
> u32 encourage_lo;
> u32 encourage_hi;
> - bool is_on;
> int ret;
>
> - ret = jh71xx_pmu_get_state(pmd, mask, &is_on);
> - if (ret) {
> - dev_dbg(pmu->dev, "unable to get current state for %s\n",
> - pmd->genpd.name);
> - return ret;
> - }
> -
> - if (is_on == on) {
> - dev_dbg(pmu->dev, "pm domain [%s] is already %sable status.\n",
> - pmd->genpd.name, on ? "en" : "dis");
> - return 0;
> - }
> -
> spin_lock_irqsave(&pmu->lock, flags);
>
> /*
> @@ -166,6 +160,29 @@ static int jh71xx_pmu_set_state(struct jh71xx_pmu_dev *pmd, u32 mask, bool on)
> return 0;
> }
>
> +static int jh71xx_pmu_set_state(struct jh71xx_pmu_dev *pmd, u32 mask, bool on)
> +{
> + struct jh71xx_pmu *pmu = pmd->pmu;
> + const struct jh71xx_pmu_match_data *match_data = pmu->match_data;
> + bool is_on;
> + int ret;
> +
> + ret = jh71xx_pmu_get_state(pmd, mask, &is_on);
> + if (ret) {
> + dev_dbg(pmu->dev, "unable to get current state for %s\n",
> + pmd->genpd.name);
> + return ret;
> + }
> +
> + if (is_on == on) {
> + dev_dbg(pmu->dev, "pm domain [%s] is already %sable status.\n",
> + pmd->genpd.name, on ? "en" : "dis");
> + return 0;
> + }
> +
> + return match_data->pmu_set_state(pmd, mask, on);
> +}
> +
> static int jh71xx_pmu_on(struct generic_pm_domain *genpd)
> {
> struct jh71xx_pmu_dev *pmd = container_of(genpd,
> @@ -226,6 +243,25 @@ static irqreturn_t jh71xx_pmu_interrupt(int irq, void *data)
> return IRQ_HANDLED;
> }
>
> +static int jh7110_pmu_parse_irq(struct platform_device *pdev, struct jh71xx_pmu *pmu)
> +{
> + struct device *dev = &pdev->dev;
> + int ret;
> +
> + pmu->irq = platform_get_irq(pdev, 0);
> + if (pmu->irq < 0)
> + return pmu->irq;
> +
> + ret = devm_request_irq(dev, pmu->irq, jh71xx_pmu_interrupt,
> + 0, pdev->name, pmu);
> + if (ret)
> + dev_err(dev, "failed to request irq\n");
> +
> + jh71xx_pmu_int_enable(pmu, JH71XX_PMU_INT_ALL_MASK & ~JH71XX_PMU_INT_PCH_FAIL, true);
> +
> + return 0;
> +}
> +
> static int jh71xx_pmu_init_domain(struct jh71xx_pmu *pmu, int index)
> {
> struct jh71xx_pmu_dev *pmd;
> @@ -275,19 +311,18 @@ static int jh71xx_pmu_probe(struct platform_device *pdev)
> if (IS_ERR(pmu->base))
> return PTR_ERR(pmu->base);
>
> - pmu->irq = platform_get_irq(pdev, 0);
> - if (pmu->irq < 0)
> - return pmu->irq;
> -
> - ret = devm_request_irq(dev, pmu->irq, jh71xx_pmu_interrupt,
> - 0, pdev->name, pmu);
> - if (ret)
> - dev_err(dev, "failed to request irq\n");
> + spin_lock_init(&pmu->lock);
>
> match_data = of_device_get_match_data(dev);
> if (!match_data)
> return -EINVAL;
>
> + ret = match_data->pmu_parse_irq(pdev, pmu);
> + if (ret) {
> + dev_err(dev, "failed to parse irq\n");
> + return ret;
> + }
> +
> pmu->genpd = devm_kcalloc(dev, match_data->num_domains,
> sizeof(struct generic_pm_domain *),
> GFP_KERNEL);
> @@ -307,9 +342,6 @@ static int jh71xx_pmu_probe(struct platform_device *pdev)
> }
> }
>
> - spin_lock_init(&pmu->lock);
> - jh71xx_pmu_int_enable(pmu, JH71XX_PMU_INT_ALL_MASK & ~JH71XX_PMU_INT_PCH_FAIL, true);
> -
> ret = of_genpd_add_provider_onecell(np, &pmu->genpd_data);
> if (ret) {
> dev_err(dev, "failed to register genpd driver: %d\n", ret);
> @@ -357,6 +389,9 @@ static const struct jh71xx_domain_info jh7110_power_domains[] = {
> static const struct jh71xx_pmu_match_data jh7110_pmu = {
> .num_domains = ARRAY_SIZE(jh7110_power_domains),
> .domain_info = jh7110_power_domains,
> + .pmu_status = JH71XX_PMU_CURR_POWER_MODE,
> + .pmu_parse_irq = jh7110_pmu_parse_irq,
> + .pmu_set_state = jh7110_pmu_set_state,
> };
>
> static const struct of_device_id jh71xx_pmu_of_match[] = {
next prev parent reply other threads:[~2023-05-10 6:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 1:53 [PATCH v3 0/5] Add JH7110 AON PMU support Changhuang Liang
2023-05-10 1:53 ` [PATCH v3 1/5] dt-bindings: power: " Changhuang Liang
2023-05-10 7:06 ` Conor Dooley
2023-05-10 7:20 ` Changhuang Liang
2023-05-10 19:51 ` Conor Dooley
2023-05-11 2:06 ` Changhuang Liang
2023-05-10 1:53 ` [PATCH v3 2/5] soc: starfive: Replace SOC_STARFIVE with ARCH_STARFIVE Changhuang Liang
2023-05-10 1:53 ` [PATCH v3 3/5] soc: starfive: Extract JH7110 pmu private operations Changhuang Liang
2023-05-10 6:51 ` Walker Chen [this message]
2023-05-10 1:53 ` [PATCH v3 4/5] soc: starfive: Add JH7110 AON PMU support Changhuang Liang
2023-05-10 1:53 ` [PATCH v3 5/5] riscv: dts: starfive: jh7110: Add AON PMU node Changhuang Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88660bc1-035c-fa7b-d541-d29bc142e043@starfivetech.com \
--to=walker.chen@starfivetech.com \
--cc=aou@eecs.berkeley.edu \
--cc=changhuang.liang@starfivetech.com \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hal.feng@starfivetech.com \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox