From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752095AbcEKWgb (ORCPT ); Wed, 11 May 2016 18:36:31 -0400 Received: from gloria.sntech.de ([95.129.55.99]:55996 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751511AbcEKWga (ORCPT ); Wed, 11 May 2016 18:36:30 -0400 From: Heiko Stuebner To: Brian Norris Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, dianders@chromium.org, Shawn Lin , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ARM64: dts: rockchip: enable eMMC for rk3399 EVB Date: Thu, 12 May 2016 00:36:20 +0200 Message-ID: <8868581.lJFUogXGzy@phil> User-Agent: KMail/4.14.10 (Linux/4.3.0-1-amd64; KDE/4.14.14; x86_64; ; ) In-Reply-To: <20160511223233.GB65449@google.com> References: <1462924975-69072-1-git-send-email-briannorris@chromium.org> <4355979.JCGxOmTVBW@phil> <20160511223233.GB65449@google.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, 11. Mai 2016, 15:32:33 schrieb Brian Norris: > On Wed, May 11, 2016 at 04:51:58PM +0200, Heiko Stuebner wrote: > > Hi Brian, > > > > Am Dienstag, 10. Mai 2016, 17:02:55 schrieb Brian Norris: > > > The 'mmc-hs400-enhanced-strobe' property has been acked by Rob > > > Herring, > > > though it's still not merged. > > > > The commit message should describe the actual change not the volatile > > environment surrounding it :-) . > > > > When I apply this patch the property-binding will have made it into a > > maintainer-tree so is not valid anymore then. That is more material for > > the "comment-section" below the "---" > > Of course. I think I just felt guilty without a commit message :) I really prefer a (even simple) message being there - although I'm not as strict as Greg and Felipe ;-) , and in cases like this I think something like "enable the newly added emmc node on the rk3399 evaluation board" should be sufficient. Heiko