From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D59FC324B1E for ; Fri, 23 Jan 2026 13:37:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769175438; cv=none; b=tJ1hWaAi+uzfW5JYJKMljjGdJ0CqmaRtpvM4L+iYCOJJ2zGsOcYgER99twmzZpoZfzzbqTUuidrDicZOXZM/ghjANVhzC3sVRdUC7HvZK/hTLwVeivP8eeQqg5Jk6owYIoaCPDQ1aq/WKL0X/DL+8ASIzL0DH3de7n7TG/5KXT4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769175438; c=relaxed/simple; bh=vNBTEDX8CrK6EKPN3jmj/Bn7V9H6xqG+FPTNEtCYoK4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=A7DmH/6Kzt2OAu8eUac9LqjG71uI+nOk3dWEsDYlxLKbFDYPqtx7GvWhIQSi8fyaFtEPyS6kUvzBSbShQVVJb9KOcAo7abP6hqCkmn4aJhrx100f6RQI/h+eSQT6Sb8qCyaEGuibKJXh1OM5QmSrXyT6QAWCaNGgQLAYzkiKxHM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=S9VFAo4j; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S9VFAo4j" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2a09a3bd9c5so17559675ad.3 for ; Fri, 23 Jan 2026 05:37:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769175436; x=1769780236; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HErKn5h8g7RQpeSo7mOtJWLCMpuawZ5piVFZViS/OmI=; b=S9VFAo4joeQsHuekfexxJ6uJNhSRasTVbWa83elu7qoDjJKW5AXw09dnjLXubnZ4d1 NWO8Ja51YEXS5yD9pyw5j4e3u/shnbRzzaq0yjXBagCTJuwkoGKkup6Ykt55B4MHbW8s A8YCxaPOhzt5B4XDyrIwbVFlUP9Rbfl6YYN1ACzKeifAqREY4d9LjKj+8Tiy4uj4Fpa5 h7Korz1UdwbcraumbWQcdzb31zRWqtd3gz0AOMtCZaul7/tWNTeELHiBXM0CtTN2um3S QjzdHoptSZoiPfU7xDJhOiYMyqM5I9CsUqf1SLw05uQhV9g4xhZXumkFCYx2jPz0EhpG Fpfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769175436; x=1769780236; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HErKn5h8g7RQpeSo7mOtJWLCMpuawZ5piVFZViS/OmI=; b=ArZAS9Qg6H1rkiuv+T/g+tHzapZ+HvON51LYjPc9rxHR11DXOEKdrXQCiDSROiAAx4 hssvBES0Y5joEWw2FyXYloJS/6wkfSTe2hEVs+9kbpKwoqnS8cfep+xvBuRyGMElndZ8 uP6RczTi5x9eOsILBYOy89wtYah+/wHmM+ZdY0is9y9vlKyDjBw9uKTocIBu9Yv7dvBO azIm/M4Z7HtFf8kNDuZT+hl7e6odvoIxlfeS54KoEJM/xvnCFDAZkvsqrV3Csojf7BiY rKKlArAEmZW4V+5CG/dFywXHxE2QafCmi82z3B/n5Of9Rten6pAoQ6wY3WoJ4r9HK9hM SH1g== X-Forwarded-Encrypted: i=1; AJvYcCVMdfN407PM4PxrfgwL5BeXBo5jlv4NlRSSxiWqDdXpZkQstbAVtVBu9jZiyrSQIVK0yA1Nz3yOscXJFcY=@vger.kernel.org X-Gm-Message-State: AOJu0YyvdzMCr4sojmSdLEMzidRzX7anWVvko5Zma8MpVErFH7kp7+Ky 77KAJnSnd9sLOoEcRpQgb4ORedKtXDVSDWkzx2FgYvZ8wtXBOJyn+bWR X-Gm-Gg: AZuq6aKIpo5DUDaYiKFsAUo06+wPiWujiulij1KDb+4mVEM0jGw5nHXB3fJkrDxrSvV GmYDm2RbfwfWqeVAkn5FyABelwsEcF3tozvTfd7Oga3zQkSYfWDff5C0o6QQXNO1nxSwcc0lr1A mUwzrwJUPzcPE3nLqUexzAvGuPTU6xlbQoEWrwj74Gamu4sU6O2bHkClD90mOPO2PdOkZj96rDb KV1kT1wAj28JUGdOlZUH9Xe/HErOUQEsaTIZPV85aGiHYCQIPYMciMAb1mP4GHbBzz5YLKY1Pfp CA9Jn8SF2dBsIvPkCHXCM6sTa7Og1clb/+dHh82iyeVN/r9ugjtTXlH/hvSdoOuN30gAQmXO610 aSnwJsGPU2POM9+ZfM/lk7PGu7xbj7p7dQLroafTwHxsjUZXV2O0c2dktqtCbkWS/c9cwkqi8po QyfSxOdby9qSJSccmyWQi2 X-Received: by 2002:a17:902:c94c:b0:2a7:b447:3389 with SMTP id d9443c01a7336-2a7fe43f266mr29851855ad.2.1769175435439; Fri, 23 Jan 2026 05:37:15 -0800 (PST) Received: from [192.168.1.4] ([43.241.121.48]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a802daa79dsm20649435ad.3.2026.01.23.05.37.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Jan 2026 05:37:14 -0800 (PST) Message-ID: <88798f9d-b765-421a-93bc-5e5b76995853@gmail.com> Date: Fri, 23 Jan 2026 19:07:10 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] staging: rtl8723bs: simplify boolean expressions To: Dan Carpenter Cc: gregkh@linuxfoundation.org, hansg@kernel.org, straube.linux@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20260115102910.10018-1-khushalchitturi@gmail.com> <20260115102910.10018-3-khushalchitturi@gmail.com> Content-Language: en-US From: Khushal Chitturi In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/18/26 5:29 PM, Dan Carpenter wrote: > On Thu, Jan 15, 2026 at 03:59:08PM +0530, Khushal Chitturi wrote: >> Simplify boolean expressions in rtw_xmit.c to >> comply with the kernel coding style >> >> Signed-off-by: Khushal Chitturi >> --- >> drivers/staging/rtl8723bs/core/rtw_xmit.c | 38 ++++++++++++----------- >> 1 file changed, 20 insertions(+), 18 deletions(-) >> >> diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c >> index bbc42db1c828..97e38ef62ac4 100644 >> --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c >> +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c >> @@ -384,7 +384,8 @@ static void update_attrib_vcs_info(struct adapter *padapter, struct xmit_frame * >> } else { >> while (true) { >> /* IOT action */ >> - if ((pmlmeinfo->assoc_AP_vendor == HT_IOT_PEER_ATHEROS) && (pattrib->ampdu_en == true) && >> + if ((pmlmeinfo->assoc_AP_vendor == HT_IOT_PEER_ATHEROS) && >> + (pattrib->ampdu_en) && > > What are these parens for? > >> (padapter->securitypriv.dot11PrivacyAlgrthm == _AES_)) { >> pattrib->vcs_mode = CTS_TO_SELF; >> break; >> @@ -420,7 +421,7 @@ static void update_attrib_vcs_info(struct adapter *padapter, struct xmit_frame * >> /* to do list: check MIMO power save condition. */ >> >> /* check AMPDU aggregation for TXOP */ >> - if (pattrib->ampdu_en == true) { >> + if (pattrib->ampdu_en) { >> pattrib->vcs_mode = RTS_CTS; >> break; >> } >> @@ -482,10 +483,10 @@ static s32 update_attrib_sec_info(struct adapter *padapter, struct pkt_attrib *p >> memset(pattrib->dot11tkiptxmickey.skey, 0, 16); >> pattrib->mac_id = psta->mac_id; >> >> - if (psta->ieee8021x_blocked == true) { >> + if (psta->ieee8021x_blocked) { >> pattrib->encrypt = 0; >> >> - if ((pattrib->ether_type != 0x888e) && (check_fwstate(pmlmepriv, WIFI_MP_STATE) == false)) { >> + if ((pattrib->ether_type != 0x888e) && (!check_fwstate(pmlmepriv, WIFI_MP_STATE))) { > > These parens? > >> res = _FAIL; >> goto exit; >> } >> @@ -639,8 +640,8 @@ static s32 update_attrib(struct adapter *padapter, struct sk_buff *pkt, struct p >> memcpy(pattrib->dst, ðerhdr.h_dest, ETH_ALEN); >> memcpy(pattrib->src, ðerhdr.h_source, ETH_ALEN); >> >> - if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) == true) || >> - (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) == true)) { >> + if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) || >> + (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE))) { > > These etc? Yes these are unnecessary, I've removed the redundant parentheses in v4. Please check the updated series. -- Regards, Khushal