From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45F55C47404 for ; Sat, 12 Oct 2019 02:07:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2463320679 for ; Sat, 12 Oct 2019 02:07:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728222AbfJLCHM (ORCPT ); Fri, 11 Oct 2019 22:07:12 -0400 Received: from smtprelay0072.hostedemail.com ([216.40.44.72]:44011 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727016AbfJLCHM (ORCPT ); Fri, 11 Oct 2019 22:07:12 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id 8DE79182CED2A; Sat, 12 Oct 2019 02:07:10 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: bite17_4300371d6934 X-Filterd-Recvd-Size: 2049 Received: from XPS-9350 (cpe-23-242-70-174.socal.res.rr.com [23.242.70.174]) (Authenticated sender: joe@perches.com) by omf07.hostedemail.com (Postfix) with ESMTPA; Sat, 12 Oct 2019 02:07:08 +0000 (UTC) Message-ID: <8886b98ca936e7150abf36aa3c9d167073eaba86.camel@perches.com> Subject: Re: [PATCH] staging: sm750fb: align arguments with open parenthesis From: Joe Perches To: Gabriela Bittencourt , outreachy-kernel@googlegroups.com, sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, lkcamp@lists.libreplanetbr.org, trivial@kernel.org Date: Fri, 11 Oct 2019 19:07:06 -0700 In-Reply-To: <20191012011956.9452-1-gabrielabittencourt00@gmail.com> References: <20191012011956.9452-1-gabrielabittencourt00@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.32.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2019-10-11 at 22:19 -0300, Gabriela Bittencourt wrote: > Cleans up checks of "Alignment should match open parenthesis" in tree sm750fb [] > diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c [] > @@ -289,7 +289,7 @@ static unsigned int deGetTransparency(struct lynx_accel *accel) > } > > int sm750_hw_imageblit(struct lynx_accel *accel, > - const char *pSrcbuf, /* pointer to start of source buffer in system memory */ > + const char *pSrcbuf, /* pointer to start of source buffer in system memory */ > u32 srcDelta, /* Pitch value (in bytes) of the source buffer, +ive means top down and -ive mean button up */ checkpatch only warns on the first unaligned argument, but all statement lines are meant to align to the open parenthesis. > u32 startBit, /* Mono data can start at any bit in a byte, this value should be 0 to 7 */ > u32 dBase, /* Address of destination: offset in frame buffer */