From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADC371624C0 for ; Sat, 14 Feb 2026 02:59:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.10 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771037962; cv=fail; b=FRLBKcvvcVl31UivmOWXhvpYeCn0AiGdHDn9DVaLxLwrxLJoU8AGMn9oxhTP5UabOGgBEK5opjZ2W+mE103ToyEN93nsLWD6dSsHqvMzGJ5LhVy3d3NwRoxuoAZXJuneYOrv+90OANLgT/l2LiZd8tpV+qQZ8+xIiS99sV/BbnI= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771037962; c=relaxed/simple; bh=Uz4g2weegjEbHRGh4+5SYV+B+Z0q6yrp598+dPc+ans=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=OR5V42fKYiP77biFaaHdw0EpsxmxT6/SO7POjHu5AxHY87EZCVgK+4MYyetbb/6VcCrgyS+nkEuErCk0NfqOUITXKoX5HdyG7b6qhyrVVCcgUlKCwUGN9YiuBYICoXgkTx+dUPYlPrDS5WG/Jj8pu6rHpaRcSkfAABn3exFO/dI= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Wh9JiGWN; arc=fail smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Wh9JiGWN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1771037960; x=1802573960; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=Uz4g2weegjEbHRGh4+5SYV+B+Z0q6yrp598+dPc+ans=; b=Wh9JiGWNCupuURMmJeEzzpou6c45XjrHeCX2t9eyKLgrYbS8hf41uNvH Zk4e7Rh4zx3JVt00g+AqfJgbFeC20vZybqfDEjVK2OmGzcYpeL0LadRfX npxIpsaa4fFXKsVR6KKRGHgfq99LdH+xADB65WRFGxg2MQ1+NPyYMv1x5 7GwX/N9S3UFv7t2I93oA7vRxHWGqJVTph1sfaV3Ep6u+CVDQUFv5K2buT gfKSk05ghopTUaDeGtKoSICFrSFKU226LsOWx39LWawN1R7rWZV+tVjOb dDVokAdD5MywBnbpifWOe+7NdFV/U5F+hCYElC7odlTHdaxvdnqnSZEav A==; X-CSE-ConnectionGUID: 1kE8/0ghTe6o14cakVTSUA== X-CSE-MsgGUID: RQClgTtSSYKjmWB0Ihxmww== X-IronPort-AV: E=McAfee;i="6800,10657,11700"; a="83587028" X-IronPort-AV: E=Sophos;i="6.21,289,1763452800"; d="scan'208";a="83587028" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Feb 2026 18:59:19 -0800 X-CSE-ConnectionGUID: l7EOenYYSCSFRL1yaPnxEg== X-CSE-MsgGUID: Yklf2vL8QTiurGy0AYJhLw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,289,1763452800"; d="scan'208";a="213099361" Received: from orsmsx902.amr.corp.intel.com ([10.22.229.24]) by orviesa008.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Feb 2026 18:59:19 -0800 Received: from ORSMSX901.amr.corp.intel.com (10.22.229.23) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.35; Fri, 13 Feb 2026 18:59:18 -0800 Received: from ORSEDG903.ED.cps.intel.com (10.7.248.13) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.35 via Frontend Transport; Fri, 13 Feb 2026 18:59:18 -0800 Received: from SA9PR02CU001.outbound.protection.outlook.com (40.93.196.26) by edgegateway.intel.com (134.134.137.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.35; Fri, 13 Feb 2026 18:59:18 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=SlR4VoX1Ng0NVpMnsh7v9LbJR8ZmR015mFQ9QdBSNqNmjpaYQzo8+BP6eT9jiYvA8/cazmDgNlsLUqU8kezkaZSIv7Ii5kaL6DISb6bGMGEeeUA/Jo1kgc4RLH8bl+HTmXDC86UOJ8N9q2zAR9txXg5NDe5TZ9ZgZNGXj7BHaQwDq8Dx8QXgrX64C0EKIwCfr9SSGBbmjf1A5+gS52cloRlOrkno+pw7p0kVxxDdzlvS+n2ZyPAZAR47fpMgJ3RTzZkwoS2kb+E2uNQv9zeZTPlDO6vkWH+iNp3lffnVRrv4TGPzBweo4oyZ/x4g3pfJHvVuq4HpWF9FRl+hHT3vHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Dq3WsDTDq4R1FhC1J2tYlbPnJnlZMt38xoxrVYj7hGI=; b=guMf/lA/3KdYNj4Q2tZ7qTUYdLYpZIJs6xXeX9Pgsvc8KFEfwHFAmLcAtXWrm/a6RlEq7WnPOVssaphx9iVk9flmzRoNV1dhIWPxmy5OM+T0eAVzpT3/t6aNaH1EYYn6l2DygYFuHfzYd3n2wPh6/7/WQ/8J7hq39HFo57360Wf2D/W1rW6lmhYEkq2qiM9HLX26jJjP+MWricBbAH8RR8sa0AJh888NTFY1h9CYU56cj4Meen9WljYOflK6v7RMZ/iRKLXGZwqP/7/RqiSWUvhhPiOs/N7Y/xYFljPhMJk/cBW4qILZqDG09s343hU8V0tkFETzxi63j0B90YOT5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6020.namprd11.prod.outlook.com (2603:10b6:8:61::19) by CO1PR11MB5153.namprd11.prod.outlook.com (2603:10b6:303:95::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.14; Sat, 14 Feb 2026 02:59:16 +0000 Received: from DM4PR11MB6020.namprd11.prod.outlook.com ([fe80::3058:1480:e4ac:5765]) by DM4PR11MB6020.namprd11.prod.outlook.com ([fe80::3058:1480:e4ac:5765%6]) with mapi id 15.20.9611.008; Sat, 14 Feb 2026 02:59:15 +0000 Message-ID: <88bf5c0c-37fe-4eb8-ab7a-4d8735f1a614@intel.com> Date: Sat, 14 Feb 2026 10:59:06 +0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/8] sched/topology: Switch to assigning "sd->shared" from s_data To: K Prateek Nayak CC: Valentin Schneider , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Shrikanth Hegde , "Gautham R. Shenoy" , "Ingo Molnar" , Peter Zijlstra , "Vincent Guittot" , Juri Lelli , References: <20260120113246.27987-1-kprateek.nayak@amd.com> <20260120113246.27987-4-kprateek.nayak@amd.com> <47c5f6eb-1622-4aeb-b9ff-6ebf63cc8097@amd.com> Content-Language: en-US From: "Chen, Yu C" In-Reply-To: <47c5f6eb-1622-4aeb-b9ff-6ebf63cc8097@amd.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: TPYP295CA0041.TWNP295.PROD.OUTLOOK.COM (2603:1096:7d0:7::19) To DM4PR11MB6020.namprd11.prod.outlook.com (2603:10b6:8:61::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6020:EE_|CO1PR11MB5153:EE_ X-MS-Office365-Filtering-Correlation-Id: 81676226-fabd-4ed2-8703-08de6b7509ae X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|7416014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?TzRZcGsxRFV3bUgzdnNPRUZJK3B4bnRGSzc3d09TdkQydHAzRE0wZVdpOWhY?= =?utf-8?B?bWdDbVdLdnpNSXoyWTZiSnBNbUNRbFg5S1pYbVhra1RhR28xQXBwZS8vMkhi?= =?utf-8?B?ZE1EUk9sMW1TR1hsYU56WkFZSXdTV3ZKejlLc2tVWTEvVGh5bXZSUXBvU0dW?= =?utf-8?B?VGlONmZjR3BOL1VFczU5ZWZJNXN0Mkh3SUVIc3daZWZwcjloVGkxNG5lUUFO?= =?utf-8?B?MWJCeFQyZFc5Y1p2WnZZMURWcll5UnBnOEtFT3ZlNTdZMGV6ZjFUWUZYSjd6?= =?utf-8?B?Sm5RdVdYV2grSkhtZzVQc2dxTks1M2JaREVkRGs3cFJEb0pxN1lYckxtZ0tI?= =?utf-8?B?b2d3eHlOajBmS09YQ0lMY3FDeWF1a29nNmJWVnJqdDdWc0tiYWNaazUzM2Jo?= =?utf-8?B?UmkvRWU0dk5xdWdyWUF2d0ErVGdqdmExcDcwVHJ1SEdpSm1ob1dIRGJJL0Y0?= =?utf-8?B?YTl1MzkydXFxRktQUGhqQk1ZTDc0a1RuM01SWEZsVVlhZFhpckg3OG9OeHp3?= =?utf-8?B?dDBFM3NvNllReFM0T0RlR3BvQm1qMlVtUEdKZXJpSmtxdlJMWlRsVXkrejZn?= =?utf-8?B?UzdpWTJyUzBsRnRzbUtGaE5FdmdrNG1lQUV1bUs3S2pOMUxaaVQ4MEE4SDdY?= =?utf-8?B?VGtkZHFOMnZ3MktSK0owT2pZRDdia1RxZDVHcXlYcC82WmNPRndKODhKcWFt?= =?utf-8?B?Rkt1ekZaVWtoMllTd2FTQWdJTlNuc29GS2dKV3d6blZKWjc4SlJFaG1KTnhh?= =?utf-8?B?bnFaSnB1bURPbjlvSlg2QllKMG1PeHRnTjcySkZDeHhCOVZJVXlXSUkwRlgr?= =?utf-8?B?OFdSa29JRWViTVRqVWhTajJrL2RWWVkrSmkrRTNUdXRVSDZ0a1Z0SU02d3RE?= =?utf-8?B?U0xoZ0NLTGVneGh3aWtwcEY0eVM3d2ZjWFYrdHk5cWwvNkF1azBzbXdDTElx?= =?utf-8?B?SVhEVEx2U2ZlNVBCRkxUZ2tPRHN3b0xWN0REU1hXdjZGSVNTTnFmc1NTRnFG?= =?utf-8?B?MndPeWVxTEliVWFhMllHaG5ud0V5WU5wUG5sVXNFRkkrOU40Q2xVM3puQzNq?= =?utf-8?B?U291aXBpNytsbVlYZUpXUGNjZXV2WmZWR0lVdnA3UHdldEdOTHU3TXlxY1pL?= =?utf-8?B?WTJmOElRN0hYZml2UXc0SW5hK0ZzSFhvTHNSbVdGSHlpNFdtb1hIMkZMMFZS?= =?utf-8?B?RkpLcEJOSCtsZHR3MnkvQnBoN1A2WnRsMEFRZDZsSm91QnRjS1QzbWhDVm9S?= =?utf-8?B?UERFdDg4TmNhUUJXaGJFMktlQi9RZmpEUVAwVEJjc0hIUEo2aW9FdTBiTHpZ?= =?utf-8?B?a1JUOFcrZFFkQXNvWSt5Zmt1bDZhSmRCTlcxaUxjbmJJMk56bFI0TzEyYmJI?= =?utf-8?B?Y3JaYzRFazNLakl0aUxweFBzbzBOM0FHdE4veEZ0cmpWS1dKR3F3bnJVWHNj?= =?utf-8?B?M3FTU2M5bC9FaHBrTzEzY1FHa210N294SGxMcUhGMjFOQjZzZENweVBwYjFJ?= =?utf-8?B?MEx4aXd3UDZma2poT3llTzh1RDJ1T3NMOXErL1NlMWZocEgwaU1QU2JMMXZj?= =?utf-8?B?bCtQRjNUbFRmRlJoVzJSQWMwc2l0ajRzUDREQTlQSEZ5dG9FaEE4c0hlMTVx?= =?utf-8?B?VExVSVY0WjNqOERHRFpGU1pReWh0UlB3K09WQlg2VHlMZHE0TzJsdTIrbEFS?= =?utf-8?B?YmlBWWtYSDRPL1FhL2RuaDMwZkJEcm1qWWVlOE1ocVVJSXRCY25jY2ZqbDI0?= =?utf-8?B?VURkSGZBNXN4MzVLK0NSZ1BkV0Eva0dtL0o2Y2pweTBkTWFUNEwzbEdpdEpz?= =?utf-8?B?Zk1JZUFvZkZjWlRwOTE4SkNSVGhFZjlPUjYvV1lrNXJrbjd3T1VPQXVCVkZp?= =?utf-8?B?eUU5aDlIb2k2Uk1zTDVXNWJPaWZMT0VKY08rOXNLM0FHVngwbGRDZG9LTnp4?= =?utf-8?B?Ly85b005Smc3bzVPQ1VrRC9LTVZGcVNhTC84b1YvMHBtQ3NOSlBMYUZPZWtM?= =?utf-8?B?ckJuWUVQelhnTWlNYmVJeGV2d0tpem0wbDVvS3A1cVE2cUlHVU5BaFdrUEdI?= =?utf-8?B?SVU2djY5WGdQNEtkd1dWa3UzOWYxMW9yL1VacWl6MG5NU2lOWDBXQjhXYmow?= =?utf-8?Q?7X8g=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB6020.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(7416014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MUNlcEtRUlpkTmwyalhheCthdVJaNlJ3K0trc2k1R2JGd1ZaRUg2UmJrT0sy?= =?utf-8?B?Vzd0L2RJeEJvMGxDNkg3WUxNRGp1UHZvQ1ZTVVN3a3FGVXhML2JTVmhESzVQ?= =?utf-8?B?am5kYkRBR1dBMmNveWMwL3ZOdjU3S0xnejJqUnlDZVFsbGhBRUUrN1NjeUdG?= =?utf-8?B?Rno0VmZzT1NsUm91ZmJDc3U3SEtiTnkzU0xCc3RnZXFSbVVzSHplMVhoMVVN?= =?utf-8?B?YlA4MHpwYk5FSm5scXV1TW05OE1Ob0VjdTBWVVppbkZaVUJmbGxlMTIyQUpS?= =?utf-8?B?TlJIblNKWjhTNDRkMXRnMWdMNENTT2VoNkNkT3NaU2VtVXlLcm1qUXdsQUtr?= =?utf-8?B?MlhNM2R0ZGJQYjlOR0pJTURYKzhKdUpzS0lNbTdqd2lORXpOOU92QllzMXFD?= =?utf-8?B?SUVRUHlmdVJoWWMyaGw3cmlZVzZSaWxtWncrVGdmYWY3b1JZNEtaVjllMUlC?= =?utf-8?B?TkwwcTVJcktpbjVwc0lhOGVydDlRTEZuVjlIdXF1aHB3c2NFOWdmeXRtcnJs?= =?utf-8?B?WkhpSTdEakJnM1U2aE1icFE5N0JtWWtrYkorWnVTNThFLzB0K0FjME4yOWpn?= =?utf-8?B?eWZLQ2drSlBSZXV2S0pjSUZ4bytjcUJxM2dpYUgxVWxBWHdUY0h6RWRsSm9R?= =?utf-8?B?TzI2MDNtMENSZ3pDNmZLcVhQYXpVeEFzU25IRXhzTVlja1Y0bDVCUFQxMUxh?= =?utf-8?B?TGVsYjR4RE9XSmUxTlFuL3MwZC9ZWlUrWE9HQUErcC9KUnZVeTlMMVlMU2sv?= =?utf-8?B?eUxyYzVMZzB5alpYajhNRnR5UThpbU5SY29LekJVQnJ0dytDMmkwcStrRWpD?= =?utf-8?B?OVhHeWJnSENVdUxWVkpqdk1iVXJrMXYzQUVteTBHUHJPS0UyMitFeFNVdjdG?= =?utf-8?B?NXhoOUc0M1NkVmlJb3ZNbS9waVRsSzdwSmV2TnBQRk16L0tkaHJaMjlJK3Jz?= =?utf-8?B?emZNUzhNQjdTWnMwUHF1THdDZkpXKzVjVllMRFNhQkpSdFFhVUU1NHhPU1lz?= =?utf-8?B?TWJJR1F6UjY4am1zb0FaaUVYSlZOVFR5d1RhazFXZzZjRDNObnp2S0tPSTQ3?= =?utf-8?B?SU5JRExQZTE5TDdhQ3hpRHRMWEd1RENCSEJJazIyWmpDdjFPNURpQk5rUnlW?= =?utf-8?B?QkR2Umx3aFN6cG1NbU5kbU9KTlluaCt1L3p3QkpjNkxkdEp6Q0FPalo2Wm1l?= =?utf-8?B?bjgxNDZvSC9SM2MrVCtrWENuWmZ6Q05ZMmd1NjJaQWpWd3JRb3FhVHNSUVVi?= =?utf-8?B?TXVpTmJUeTVUdUYxVzA0a2VWODkzQlJxZEV1NTk3OFVVOS9qZkNxNGdxN0Nv?= =?utf-8?B?aFdTd1JtSXZwY1Q2V2FZd2JxbWFOQUhtaFg5UDFuVWFCbktVaHdjT3o0Zk1a?= =?utf-8?B?eE9KeGVWQzFoeHlRQWl0YkhtME14TUttNUFkSkwxOGpiL3EzemFib2RGK2Fa?= =?utf-8?B?b1I3R1RFWDljUnNocEkzT1dYNWNON3hTVitlTkFFYnoxeElqTXpzaEJXOEQv?= =?utf-8?B?clJKWGM4WWRIUjUyWGVDUE1laU5BbTZRYlJKNnhJOFFDak9VM2pzMUNkMVVw?= =?utf-8?B?Qi93dk5VdVpZNUJMWHRPRVRicDI3Z244ZEg2VXRLbUJTVGROS0F0L1J1Yllj?= =?utf-8?B?YlpMallDNlhvblVpVEQ2QlluZzg4MXc5SWZRWEhYcHJac1NwRzRwSEY2SEh2?= =?utf-8?B?MTF0WWFERmJGbzJMekovcWludDBIRTB2TkpaNWlBSC9tK0NYS0tyUTZKRTlF?= =?utf-8?B?UXFmNUtKNWVBZnpKMXY1cUd5Y1kwVHVXZEorWTJIRE5TNENPb1VVYUJKdjZL?= =?utf-8?B?RzlhODgzb1EyWVE1a0pIV1dNSmhqZFlSMWE2L29ZSjlZQ1lLYXFlbzh5U0NQ?= =?utf-8?B?Ukd6Nmg3S3VRYVZBbDBVNitFK3RwNHIyQ2FwRnZYanlML3h1ODdPazZMbFpt?= =?utf-8?B?MU51d2Vjb3oxalg3Q1pEUDlzY0xMWEZIRlhUUHhLcFBsaGpNWFh3Vkg0K1Z1?= =?utf-8?B?cG10T2Qycnp3SHNzRUFlSlZtMUh3WHRwQU5pSHgzbFBKVktTMDd6eE5lOXVv?= =?utf-8?B?c2d6UnA0VExVTTBxK2pQS1ZTVkJWT0E2ellMamUwREExNEQzZkZyMy92Vklk?= =?utf-8?B?Z2tMRUtDM3pMUjRJZDRqcWxWLzZ0cGgxdWpWQ2Y3SC9HOTVwL25TRlNNWHpq?= =?utf-8?B?THN6Y1dDVDFQZUpQSnJOeitXMTdqRjgrTmtkUG90ZU44eG9wQnJ3VnpTdzBj?= =?utf-8?B?aFJCV3QrOWNLWXRGTFQxLzU2NDV6SVZnRTYwNTAvTEFLakl0VW83QXMzOEF0?= =?utf-8?B?WktobGtEU0pXcXNCdktNd28wN21qclpSVkVPaGhraWxoT3FONTJrUT09?= X-MS-Exchange-CrossTenant-Network-Message-Id: 81676226-fabd-4ed2-8703-08de6b7509ae X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6020.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2026 02:59:15.6003 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tWjEId6a81XKL+8scx52pUWVVsl2qr8VqIAjA+XdHUZd2Y52hYitnSTemc0UQWjmZcAdaI21WiCYFdBZmFc3SQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5153 X-OriginatorOrg: intel.com On 2/6/2026 1:20 PM, K Prateek Nayak wrote: > Hello Valentin, > > On 2/5/2026 10:23 PM, Valentin Schneider wrote: >> On 20/01/26 11:32, K Prateek Nayak wrote: [...] >> >> We now have two if's looking for the highest_flag_domain(i, SD_SHARE_LLC), >> but given this needs to write the sd->imb_numa_nr for every SD I couldn't >> factorize this into something that looked sane :( > > Yeah! The "imb_numa_nr" cares about the "sd_llc" *after* we've crossed > it and "sd->shared" assignment cares when we are *at* the sd_llc. > > Since we have to assign the "sd->shared" before claim_allocations(), > I couldn't find a better spot to assign it. > > That said, "imb_numa_nr" calculation can be modified to use the "sd_llc" > and its "parent". I'll let you be the judge of whether the following is > better or worse ;-) > > (Only build tested) > > diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c > index ac268da91778..e98bb812de35 100644 > --- a/kernel/sched/topology.c > +++ b/kernel/sched/topology.c > @@ -2614,13 +2614,23 @@ build_sched_domains(const struct cpumask *cpu_map, struct sched_domain_attr *att > unsigned int imb_span = 1; > > for (sd = *per_cpu_ptr(d.sd, i); sd; sd = sd->parent) { > - struct sched_domain *child = sd->child; > + struct sched_domain *parent = sd->parent; > > - if (!(sd->flags & SD_SHARE_LLC) && child && > - (child->flags & SD_SHARE_LLC)) { > - struct sched_domain __rcu *top_p; > + /* Topmost SD_SHARE_LLC domain. */ > + if ((sd->flags & SD_SHARE_LLC) && > + (!parent || !(parent->flags & SD_SHARE_LLC))) { > + int sd_id = cpumask_first(sched_domain_span(sd)); > + struct sched_domain *top_p; > unsigned int nr_llcs; > > + sd->shared = *per_cpu_ptr(d.sds, sd_id); > + atomic_set(&sd->shared->nr_busy_cpus, sd->span_weight); > + atomic_inc(&sd->shared->ref); > + > + /* No SD_NUMA domains. */ > + if (!parent) > + break; > + > /* > * For a single LLC per node, allow an > * imbalance up to 12.5% of the node. This is > @@ -2641,7 +2651,7 @@ build_sched_domains(const struct cpumask *cpu_map, struct sched_domain_attr *att > * factors and that there is a correlation > * between LLCs and memory channels. > */ > - nr_llcs = sd->span_weight / child->span_weight; > + nr_llcs = parent->span_weight / sd->span_weight; > if (nr_llcs == 1) > imb = sd->span_weight >> 3; > else > @@ -2650,11 +2660,11 @@ build_sched_domains(const struct cpumask *cpu_map, struct sched_domain_attr *att > sd->imb_numa_nr = imb; > > /* Set span based on the first NUMA domain. */ > - top_p = sd->parent; > + top_p = parent; maybe top_p = parent->parent thanks, Chenyu