From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4718C64E8A for ; Mon, 30 Nov 2020 11:46:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4B5A8206C0 for ; Mon, 30 Nov 2020 11:46:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="wot4XbfK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729125AbgK3Lqj (ORCPT ); Mon, 30 Nov 2020 06:46:39 -0500 Received: from mail.kernel.org ([198.145.29.99]:60042 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727718AbgK3Lqj (ORCPT ); Mon, 30 Nov 2020 06:46:39 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 54E33206C0; Mon, 30 Nov 2020 11:45:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606736758; bh=Krtww9Pc3dyFLVs/ZzWwRxmRLXRV8pdUOWtwJ4m5orE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=wot4XbfKdNCDGe6aDrfoM5jDGngUVcjoKT+i71oiX8WI2Y+oVaRoSdCMnmjFw2LAy DU7qAowqz6c306IUz1BWzxd8NbY40BiQ+lk8jLv3HOc00DGtbhH8wLzk5jQ2bXVWOW zCJNO/T6cl9C3jCwBt7PXgHtzW5p55n7HPeLByJo= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kjhcy-00EfyS-6v; Mon, 30 Nov 2020 11:45:56 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 30 Nov 2020 11:45:56 +0000 From: Marc Zyngier To: linux-kernel@vger.kernel.org Cc: Thomas Gleixner Subject: Re: [PATCH] genirq/irqdomain: Don't try to free an interrupt that has no mapping In-Reply-To: <20201129135551.396777-1-maz@kernel.org> References: <20201129135551.396777-1-maz@kernel.org> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <88f1748b95169e79bb84f852dbea8fce@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: linux-kernel@vger.kernel.org, tglx@linutronix.de X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-11-29 13:55, Marc Zyngier wrote: > When an interrupt allocation fails for N interrupts, it is pretty > common for the error handling code to free the same number of > interrupts, > no matter how many interrupts have actually been allocated. > > This may result in the domain freeing code to be unexpectedly called > for interrupts that have no mapping in that domain. Things end pretty > badly. > > Instead, add some checks to irq_domain_free_irqs_hierarchy() to make > sure that we don't follow the hierarchy if no mapping exists for > a given interrupt. > > Signed-off-by: Marc Zyngier A for a good measure: Fixes: 6a6544e520abe ("genirq/irqdomain: Remove auto-recursive hierarchy support") Thanks, M. -- Jazz is not dead. It just smells funny...