From: linmiaohe <linmiaohe@huawei.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: "pbonzini@redhat.com" <pbonzini@redhat.com>,
"rkrcmar@redhat.com" <rkrcmar@redhat.com>,
"vkuznets@redhat.com" <vkuznets@redhat.com>,
"wanpengli@tencent.com" <wanpengli@tencent.com>,
"jmattson@google.com" <jmattson@google.com>,
"joro@8bytes.org" <joro@8bytes.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"bp@alien8.de" <bp@alien8.de>, "hpa@zytor.com" <hpa@zytor.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH 0/6] Fix various comment errors
Date: Thu, 12 Dec 2019 02:08:32 +0000 [thread overview]
Message-ID: <88f5931859484959bd80a48edbbe1104@huawei.com> (raw)
Sean Christopherson wrote:
> On Wed, Dec 11, 2019 at 02:26:19PM +0800, linmiaohe wrote:
>> From: Miaohe Lin <linmiaohe@huawei.com>
>>
>> Miaohe Lin (6):
>> KVM: Fix some wrong function names in comment
>> KVM: Fix some out-dated function names in comment
>> KVM: Fix some comment typos and missing parentheses
>> KVM: Fix some grammar mistakes
>> KVM: hyperv: Fix some typos in vcpu unimpl info
>> KVM: Fix some writing mistakes
>
>Regarding the patch organizing, I'd probably group the comment changes based on what files they touch as opposed to what type of comment issue they're fixing.
>
>E.g. three patches for the comments
>
> KVM: VMX: Fix comment blah blah blah
> KVM: x86: Fix comment blah blah blah
> KVM: Fix comment blah blah blah
>
>and one patch for the print typo in hyperv
>
> KVM: hyperv: Fix some typos in vcpu unimpl info
>
>For KVM, the splits don't matter _that_ much since they more or less all get routed through the maintainers/reviewers, but it is nice when patches can be contained to specific subsystems/areas as it allows people to easily skip over patches that aren't relevant to them.
>
Many thanks for your advice and patient explanation. I feel sorry for my poor patch organizing.
I would reorganize my patches. Thanks again.
next reply other threads:[~2019-12-12 2:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 2:08 linmiaohe [this message]
2019-12-12 2:59 ` [PATCH 0/6] Fix various comment errors Xiaoyao Li
-- strict thread matches above, loose matches on Subject: below --
2019-12-11 6:26 linmiaohe
2019-12-11 16:01 ` Sean Christopherson
2020-01-15 17:56 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88f5931859484959bd80a48edbbe1104@huawei.com \
--to=linmiaohe@huawei.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox